Fix Docker deployments 🐳 #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomd
commented
Jun 19, 2018
| @@ -85,7 +85,7 @@ function stage(cwd, {alias}) { | |||
| if (!url) return reject(new Error('Deployment failed')); | |||
| log.info(`> Setting ${url} to alias ${alias}`); | |||
| const aliasProc = exec(now(`alias set ${url} ${alias}`), {cwd}); | |||
| aliasProc.stderr.on('data', (error) => {aliasError = error;}); | |||
| aliasProc.stderr.on('data', (error) => {aliasError = error.replace('\u001b[2K\u001b[G', '');}); | |||
There was a problem hiding this comment.
For some reason the latest version of now outputs escape sequences into stderr and it was breaking here..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47, fixes #39, #43
I've updated the Dockerfile to use the
node:10-alpineimage, and to pull the latest version ofnowwith Alpine support (11.2.1). I would have pulled8.3.9which is what the rest of the code uses, but the binary doesn't seem to work on Alpine at all 🤔I've tested pretty extensively and it seems to be quite stable ✅
I'd like to make another PR to update
nowversion that we pull fornpmbased deployments to11.2.1, that way we shouldn't have any compatibility issues fromnowacrossnpmanddockerdeployments.