Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Is there a option in SDK to find latitude and longitude based on city #169

Open
gopurx opened this issue Oct 2, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@gopurx
Copy link

gopurx commented Oct 2, 2024

Problem Statement
Trying to find option to get lat and long of city while creating static_ips

Proposed Solution
Extend create_static_ip to accept city,state,country to populate or option to search for lat and long to pass it on while creating the same

Additional Context
Add any other context, references or screenshots about the feature request here.

@willguibr willguibr self-assigned this Oct 2, 2024
@willguibr willguibr added the enhancement New feature or request label Oct 2, 2024
@willguibr
Copy link
Member

@gopurx I assume your ask is to enhance the add_static_ip method here.
The enhancement would involve implicitly invoke the method of the following method get_geo_by_ip here, and exporting the latitude and longitude values returned in the API response and passing it to the add_static_ip.

{
  "city_geo_id": 4269447,
  "state_geo_id": 4273857,
  "latitude": 37.6325999,
  "longitude": -97.7724999,
  "city_name": "Cheney",
  "state_name": "Kansas",
  "country_name": "United States",
  "country_code": "US",
  "postal_code": "67025",
  "continent_code": "NA"
}

We'll look into extending this functionality. Please confirm if our understanding is correct. In the meantime you can leverage the get_geo_by_ip here and it will give you the expected results you're looking for.

Zscaler DevRel.

@gopurx
Copy link
Author

gopurx commented Oct 4, 2024

@willguibr I am looking for an ability to derive lat and long based on City, State vs IP. There are cases we are observing the City is wrongly derived while using get_geo_by_ip

@willguibr
Copy link
Member

@gopurx Can you please provide an example where you're "observing the City is wrongly derived while using get_geo_by_ip"
Thanks
Zscaler DevRel

@gopurx
Copy link
Author

gopurx commented Oct 7, 2024

Sorry, I cannot share information about IPs being used. I will be testing with bunch of locations and IPs pretty soon and share the observations here

@willguibr
Copy link
Member

@gopurx In this case, please raise a ticket with Zscaler support so they can redirect to the appropriate team for investigation and set up a potential call.

Zscaler DevRel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants