[Feature Request] Homebridge v2.0 Breaking Updates #146
Assignees
Labels
Comments
|
Tagging @uswong as well to keep in the loop. |
|
Hey Mitch, Thanks for the heads up. Was your AdvAir impacted too? Would you happen to know if the changes required will be backward compatible? ttyl, |
|
Hey John, I think AdvAir will be affected through Cmd4, but I would need to find some time to figure out if AdvAir is affected separately. My testing was as simple as update Homebridge and see which plug-ins threw errors causing a reboot cycle; it is hard to test AdvAir this same way when Cmd4 is already doing it :) Anyway, glad I gave you a heads up as I know you have a lot of people rely on your plug-in. |
|
@ztalbot2000 I spent a bit more time trying to collect some logs for you and find some strange behaviour. It seems the plug-in will fail to initialise altogether, it then removes itself as a child bridge if it is one and then will refuse to load up again until a reboot of Homebridge is attempted. Trying to reboot the child bridge in the plug-ins tab does nothing (I think because it removes itself as a child bridge). This means it does not cause a Homebridge reboot seqeunce but does mean the plug-in fails. Let me know if you need me to collect more logs, but will suggest with the little spare time on my hands currently that you could spin up a Homebridge instance, install Cmd4, then upgrade Homebridge to the beta and see what happens. |
|
Hi Mitch,
Thanks very much for this. It's an odd traceback. It complains about
"Characteristic.Formats.BOOL". Characteristics is a passed in type from
homebridge. They must have changed it, which is usually a big no no.
ttyl,
John
…On Sat, Jul 27, 2024 at 4:04 AM Mitch Williams ***@***.***> wrote:
@ztalbot2000 <https://github.com/ztalbot2000> I spent a bit more time
trying to collect some logs for you and find some strange behaviour. It
seems the plug-in will fail to initialise altogether, it then removes
itself as a child bridge if it is one and then will refuse to load up again
until a reboot of Homebridge is attempted. Trying to reboot the child
bridge in the plug-ins tab does nothing (I think because it removes itself
as a child bridge). This means it does not cause a Homebridge reboot
seqeunce but does mean the plug-in fails.
[27/07/2024, 3:57:33 pm] Loaded plugin: ***@***.***
[27/07/2024, 3:57:33 pm] ====================
[27/07/2024, 3:57:33 pm] ERROR INITIALIZING PLUGIN homebridge-cmd4:
[27/07/2024, 3:57:33 pm] TypeError: Cannot read properties of undefined (reading 'BOOL')
at Object.init (/usr/local/lib/node_modules/homebridge-cmd4/lib/CMD4_CHAR_TYPE_ENUMS.js:61:44)
at Plugin.default [as pluginInitializer] (/usr/local/lib/node_modules/homebridge-cmd4/index.js:41:44)
at Plugin.initialize (/usr/local/lib/node_modules/homebridge/src/plugin.ts:244:17)
at PluginManager.initializePlugin (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:173:20)
at PluginManager.initializeInstalledPlugins (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:162:18)
at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:161:5)
[27/07/2024, 3:57:33 pm] ====================
[27/07/2024, 3:57:33 pm] ---
Let me know if you need me to collect more logs, but will suggest with the
little spare time on my hands currently that you could spin up a Homebridge
instance, install Cmd4, then upgrade Homebridge to the beta and see what
happens.
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCXYKCV4YORI52EDRI5LZONIAJAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGAZDMOJQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hey Mitch,
Good news, I was able to duplicate your traceback.
ttyl,
John
…On Sat, Jul 27, 2024 at 8:49 AM John Talbot ***@***.***> wrote:
Hi Mitch,
Thanks very much for this. It's an odd traceback. It complains about
"Characteristic.Formats.BOOL". Characteristics is a passed in type from
homebridge. They must have changed it, which is usually a big no no.
ttyl,
John
On Sat, Jul 27, 2024 at 4:04 AM Mitch Williams ***@***.***>
wrote:
> @ztalbot2000 <https://github.com/ztalbot2000> I spent a bit more time
> trying to collect some logs for you and find some strange behaviour. It
> seems the plug-in will fail to initialise altogether, it then removes
> itself as a child bridge if it is one and then will refuse to load up again
> until a reboot of Homebridge is attempted. Trying to reboot the child
> bridge in the plug-ins tab does nothing (I think because it removes itself
> as a child bridge). This means it does not cause a Homebridge reboot
> seqeunce but does mean the plug-in fails.
>
> [27/07/2024, 3:57:33 pm] Loaded plugin: ***@***.***
> [27/07/2024, 3:57:33 pm] ====================
> [27/07/2024, 3:57:33 pm] ERROR INITIALIZING PLUGIN homebridge-cmd4:
> [27/07/2024, 3:57:33 pm] TypeError: Cannot read properties of undefined (reading 'BOOL')
> at Object.init (/usr/local/lib/node_modules/homebridge-cmd4/lib/CMD4_CHAR_TYPE_ENUMS.js:61:44)
> at Plugin.default [as pluginInitializer] (/usr/local/lib/node_modules/homebridge-cmd4/index.js:41:44)
> at Plugin.initialize (/usr/local/lib/node_modules/homebridge/src/plugin.ts:244:17)
> at PluginManager.initializePlugin (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:173:20)
> at PluginManager.initializeInstalledPlugins (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:162:18)
> at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:161:5)
> [27/07/2024, 3:57:33 pm] ====================
> [27/07/2024, 3:57:33 pm] ---
>
> Let me know if you need me to collect more logs, but will suggest with
> the little spare time on my hands currently that you could spin up a
> Homebridge instance, install Cmd4, then upgrade Homebridge to the beta and
> see what happens.
>
> —
> Reply to this email directly, view it on GitHub
> <#146 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABSBCXYKCV4YORI52EDRI5LZONIAJAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGAZDMOJQGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
Hey Mitch,
Getting closer. Cmd4 has the latest stuff under b_Ver8. What I found so
far is that the Characteristic type provided by homebridge no longer has
the Formats,Perms & Units sub types. These types must be taken directly
from api.hap. The branch so far fixes these and is backward compatible,
but there is a further issue with valid values. I'll check this later as
that's it for now.
ttyl,
John
…On Sat, Jul 27, 2024 at 9:10 AM John Talbot ***@***.***> wrote:
Hey Mitch,
Good news, I was able to duplicate your traceback.
ttyl,
John
On Sat, Jul 27, 2024 at 8:49 AM John Talbot ***@***.***> wrote:
> Hi Mitch,
>
> Thanks very much for this. It's an odd traceback. It complains about
> "Characteristic.Formats.BOOL". Characteristics is a passed in type from
> homebridge. They must have changed it, which is usually a big no no.
>
> ttyl,
> John
>
> On Sat, Jul 27, 2024 at 4:04 AM Mitch Williams ***@***.***>
> wrote:
>
>> @ztalbot2000 <https://github.com/ztalbot2000> I spent a bit more time
>> trying to collect some logs for you and find some strange behaviour. It
>> seems the plug-in will fail to initialise altogether, it then removes
>> itself as a child bridge if it is one and then will refuse to load up again
>> until a reboot of Homebridge is attempted. Trying to reboot the child
>> bridge in the plug-ins tab does nothing (I think because it removes itself
>> as a child bridge). This means it does not cause a Homebridge reboot
>> seqeunce but does mean the plug-in fails.
>>
>> [27/07/2024, 3:57:33 pm] Loaded plugin: ***@***.***
>> [27/07/2024, 3:57:33 pm] ====================
>> [27/07/2024, 3:57:33 pm] ERROR INITIALIZING PLUGIN homebridge-cmd4:
>> [27/07/2024, 3:57:33 pm] TypeError: Cannot read properties of undefined (reading 'BOOL')
>> at Object.init (/usr/local/lib/node_modules/homebridge-cmd4/lib/CMD4_CHAR_TYPE_ENUMS.js:61:44)
>> at Plugin.default [as pluginInitializer] (/usr/local/lib/node_modules/homebridge-cmd4/index.js:41:44)
>> at Plugin.initialize (/usr/local/lib/node_modules/homebridge/src/plugin.ts:244:17)
>> at PluginManager.initializePlugin (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:173:20)
>> at PluginManager.initializeInstalledPlugins (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:162:18)
>> at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:161:5)
>> [27/07/2024, 3:57:33 pm] ====================
>> [27/07/2024, 3:57:33 pm] ---
>>
>> Let me know if you need me to collect more logs, but will suggest with
>> the little spare time on my hands currently that you could spin up a
>> Homebridge instance, install Cmd4, then upgrade Homebridge to the beta and
>> see what happens.
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#146 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ABSBCXYKCV4YORI52EDRI5LZONIAJAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGAZDMOJQGY>
>> .
>> You are receiving this because you were mentioned.Message ID:
>> ***@***.***>
>>
>
|
|
Hi Mitch,
Sio TargetAirQuality and TargetSlatState are now deprecated, this gave a
few init problems that I've corrected. the branch b_Ver8 should work though
I want to check how docs are created and the example config.json uses them.
night,
John
…On Sat, Jul 27, 2024 at 12:05 PM John Talbot ***@***.***> wrote:
Hey Mitch,
Getting closer. Cmd4 has the latest stuff under b_Ver8. What I found so
far is that the Characteristic type provided by homebridge no longer has
the Formats,Perms & Units sub types. These types must be taken directly
from api.hap. The branch so far fixes these and is backward compatible,
but there is a further issue with valid values. I'll check this later as
that's it for now.
ttyl,
John
On Sat, Jul 27, 2024 at 9:10 AM John Talbot ***@***.***> wrote:
> Hey Mitch,
>
> Good news, I was able to duplicate your traceback.
>
> ttyl,
> John
>
> On Sat, Jul 27, 2024 at 8:49 AM John Talbot ***@***.***>
> wrote:
>
>> Hi Mitch,
>>
>> Thanks very much for this. It's an odd traceback. It complains about
>> "Characteristic.Formats.BOOL". Characteristics is a passed in type from
>> homebridge. They must have changed it, which is usually a big no no.
>>
>> ttyl,
>> John
>>
>> On Sat, Jul 27, 2024 at 4:04 AM Mitch Williams ***@***.***>
>> wrote:
>>
>>> @ztalbot2000 <https://github.com/ztalbot2000> I spent a bit more time
>>> trying to collect some logs for you and find some strange behaviour. It
>>> seems the plug-in will fail to initialise altogether, it then removes
>>> itself as a child bridge if it is one and then will refuse to load up again
>>> until a reboot of Homebridge is attempted. Trying to reboot the child
>>> bridge in the plug-ins tab does nothing (I think because it removes itself
>>> as a child bridge). This means it does not cause a Homebridge reboot
>>> seqeunce but does mean the plug-in fails.
>>>
>>> [27/07/2024, 3:57:33 pm] Loaded plugin: ***@***.***
>>> [27/07/2024, 3:57:33 pm] ====================
>>> [27/07/2024, 3:57:33 pm] ERROR INITIALIZING PLUGIN homebridge-cmd4:
>>> [27/07/2024, 3:57:33 pm] TypeError: Cannot read properties of undefined (reading 'BOOL')
>>> at Object.init (/usr/local/lib/node_modules/homebridge-cmd4/lib/CMD4_CHAR_TYPE_ENUMS.js:61:44)
>>> at Plugin.default [as pluginInitializer] (/usr/local/lib/node_modules/homebridge-cmd4/index.js:41:44)
>>> at Plugin.initialize (/usr/local/lib/node_modules/homebridge/src/plugin.ts:244:17)
>>> at PluginManager.initializePlugin (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:173:20)
>>> at PluginManager.initializeInstalledPlugins (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:162:18)
>>> at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:161:5)
>>> [27/07/2024, 3:57:33 pm] ====================
>>> [27/07/2024, 3:57:33 pm] ---
>>>
>>> Let me know if you need me to collect more logs, but will suggest with
>>> the little spare time on my hands currently that you could spin up a
>>> Homebridge instance, install Cmd4, then upgrade Homebridge to the beta and
>>> see what happens.
>>>
>>> —
>>> Reply to this email directly, view it on GitHub
>>> <#146 (comment)>,
>>> or unsubscribe
>>> <https://github.com/notifications/unsubscribe-auth/ABSBCXYKCV4YORI52EDRI5LZONIAJAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGAZDMOJQGY>
>>> .
>>> You are receiving this because you were mentioned.Message ID:
>>> ***@***.***>
>>>
>>
|
|
Hey Mitch,
I just published to npm v8.00-beta1. It should be backward compatible to
your plugin.
Ttyl,
John
…On Sat, Jul 27, 2024 at 11:21 PM John Talbot ***@***.***> wrote:
Hi Mitch,
Sio TargetAirQuality and TargetSlatState are now deprecated, this gave a
few init problems that I've corrected. the branch b_Ver8 should work though
I want to check how docs are created and the example config.json uses them.
night,
John
On Sat, Jul 27, 2024 at 12:05 PM John Talbot ***@***.***>
wrote:
> Hey Mitch,
>
> Getting closer. Cmd4 has the latest stuff under b_Ver8. What I found
> so far is that the Characteristic type provided by homebridge no longer has
> the Formats,Perms & Units sub types. These types must be taken directly
> from api.hap. The branch so far fixes these and is backward compatible,
> but there is a further issue with valid values. I'll check this later as
> that's it for now.
>
> ttyl,
> John
>
> On Sat, Jul 27, 2024 at 9:10 AM John Talbot ***@***.***>
> wrote:
>
>> Hey Mitch,
>>
>> Good news, I was able to duplicate your traceback.
>>
>> ttyl,
>> John
>>
>> On Sat, Jul 27, 2024 at 8:49 AM John Talbot ***@***.***>
>> wrote:
>>
>>> Hi Mitch,
>>>
>>> Thanks very much for this. It's an odd traceback. It complains about
>>> "Characteristic.Formats.BOOL". Characteristics is a passed in type from
>>> homebridge. They must have changed it, which is usually a big no no.
>>>
>>> ttyl,
>>> John
>>>
>>> On Sat, Jul 27, 2024 at 4:04 AM Mitch Williams <
>>> ***@***.***> wrote:
>>>
>>>> @ztalbot2000 <https://github.com/ztalbot2000> I spent a bit more time
>>>> trying to collect some logs for you and find some strange behaviour. It
>>>> seems the plug-in will fail to initialise altogether, it then removes
>>>> itself as a child bridge if it is one and then will refuse to load up again
>>>> until a reboot of Homebridge is attempted. Trying to reboot the child
>>>> bridge in the plug-ins tab does nothing (I think because it removes itself
>>>> as a child bridge). This means it does not cause a Homebridge reboot
>>>> seqeunce but does mean the plug-in fails.
>>>>
>>>> [27/07/2024, 3:57:33 pm] Loaded plugin: ***@***.***
>>>> [27/07/2024, 3:57:33 pm] ====================
>>>> [27/07/2024, 3:57:33 pm] ERROR INITIALIZING PLUGIN homebridge-cmd4:
>>>> [27/07/2024, 3:57:33 pm] TypeError: Cannot read properties of undefined (reading 'BOOL')
>>>> at Object.init (/usr/local/lib/node_modules/homebridge-cmd4/lib/CMD4_CHAR_TYPE_ENUMS.js:61:44)
>>>> at Plugin.default [as pluginInitializer] (/usr/local/lib/node_modules/homebridge-cmd4/index.js:41:44)
>>>> at Plugin.initialize (/usr/local/lib/node_modules/homebridge/src/plugin.ts:244:17)
>>>> at PluginManager.initializePlugin (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:173:20)
>>>> at PluginManager.initializeInstalledPlugins (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:162:18)
>>>> at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:161:5)
>>>> [27/07/2024, 3:57:33 pm] ====================
>>>> [27/07/2024, 3:57:33 pm] ---
>>>>
>>>> Let me know if you need me to collect more logs, but will suggest with
>>>> the little spare time on my hands currently that you could spin up a
>>>> Homebridge instance, install Cmd4, then upgrade Homebridge to the beta and
>>>> see what happens.
>>>>
>>>> —
>>>> Reply to this email directly, view it on GitHub
>>>> <#146 (comment)>,
>>>> or unsubscribe
>>>> <https://github.com/notifications/unsubscribe-auth/ABSBCXYKCV4YORI52EDRI5LZONIAJAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGAZDMOJQGY>
>>>> .
>>>> You are receiving this because you were mentioned.Message ID:
>>>> ***@***.***>
>>>>
>>>
|
|
Hey Mitch,
I think I spoke to soon. Found an issue
…On Sun, Jul 28, 2024 at 8:08 AM John Talbot ***@***.***> wrote:
Hey Mitch,
I just published to npm v8.00-beta1. It should be backward compatible to
your plugin.
Ttyl,
John
On Sat, Jul 27, 2024 at 11:21 PM John Talbot ***@***.***>
wrote:
> Hi Mitch,
>
> Sio TargetAirQuality and TargetSlatState are now deprecated, this gave
> a few init problems that I've corrected. the branch b_Ver8 should work
> though I want to check how docs are created and the example config.json
> uses them.
>
> night,
> John
>
> On Sat, Jul 27, 2024 at 12:05 PM John Talbot ***@***.***>
> wrote:
>
>> Hey Mitch,
>>
>> Getting closer. Cmd4 has the latest stuff under b_Ver8. What I found
>> so far is that the Characteristic type provided by homebridge no longer has
>> the Formats,Perms & Units sub types. These types must be taken directly
>> from api.hap. The branch so far fixes these and is backward compatible,
>> but there is a further issue with valid values. I'll check this later as
>> that's it for now.
>>
>> ttyl,
>> John
>>
>> On Sat, Jul 27, 2024 at 9:10 AM John Talbot ***@***.***>
>> wrote:
>>
>>> Hey Mitch,
>>>
>>> Good news, I was able to duplicate your traceback.
>>>
>>> ttyl,
>>> John
>>>
>>> On Sat, Jul 27, 2024 at 8:49 AM John Talbot ***@***.***>
>>> wrote:
>>>
>>>> Hi Mitch,
>>>>
>>>> Thanks very much for this. It's an odd traceback. It complains
>>>> about "Characteristic.Formats.BOOL". Characteristics is a passed in type
>>>> from homebridge. They must have changed it, which is usually a big no no.
>>>>
>>>> ttyl,
>>>> John
>>>>
>>>> On Sat, Jul 27, 2024 at 4:04 AM Mitch Williams <
>>>> ***@***.***> wrote:
>>>>
>>>>> @ztalbot2000 <https://github.com/ztalbot2000> I spent a bit more
>>>>> time trying to collect some logs for you and find some strange behaviour.
>>>>> It seems the plug-in will fail to initialise altogether, it then removes
>>>>> itself as a child bridge if it is one and then will refuse to load up again
>>>>> until a reboot of Homebridge is attempted. Trying to reboot the child
>>>>> bridge in the plug-ins tab does nothing (I think because it removes itself
>>>>> as a child bridge). This means it does not cause a Homebridge reboot
>>>>> seqeunce but does mean the plug-in fails.
>>>>>
>>>>> [27/07/2024, 3:57:33 pm] Loaded plugin: ***@***.***
>>>>> [27/07/2024, 3:57:33 pm] ====================
>>>>> [27/07/2024, 3:57:33 pm] ERROR INITIALIZING PLUGIN homebridge-cmd4:
>>>>> [27/07/2024, 3:57:33 pm] TypeError: Cannot read properties of undefined (reading 'BOOL')
>>>>> at Object.init (/usr/local/lib/node_modules/homebridge-cmd4/lib/CMD4_CHAR_TYPE_ENUMS.js:61:44)
>>>>> at Plugin.default [as pluginInitializer] (/usr/local/lib/node_modules/homebridge-cmd4/index.js:41:44)
>>>>> at Plugin.initialize (/usr/local/lib/node_modules/homebridge/src/plugin.ts:244:17)
>>>>> at PluginManager.initializePlugin (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:173:20)
>>>>> at PluginManager.initializeInstalledPlugins (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:162:18)
>>>>> at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:161:5)
>>>>> [27/07/2024, 3:57:33 pm] ====================
>>>>> [27/07/2024, 3:57:33 pm] ---
>>>>>
>>>>> Let me know if you need me to collect more logs, but will suggest
>>>>> with the little spare time on my hands currently that you could spin up a
>>>>> Homebridge instance, install Cmd4, then upgrade Homebridge to the beta and
>>>>> see what happens.
>>>>>
>>>>> —
>>>>> Reply to this email directly, view it on GitHub
>>>>> <#146 (comment)>,
>>>>> or unsubscribe
>>>>> <https://github.com/notifications/unsubscribe-auth/ABSBCXYKCV4YORI52EDRI5LZONIAJAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGAZDMOJQGY>
>>>>> .
>>>>> You are receiving this because you were mentioned.Message ID:
>>>>> ***@***.***>
>>>>>
>>>>
|
|
Hi Mitch.
P[ublished beta.2. IT runs under homebridge v2, but a lot of tests fail
for bridged devices and also some of my tests check the output of
homebridge and they added messages that I do not account for.
You should give this a go though.
ttyl,
John
…On Sun, Jul 28, 2024 at 3:58 PM John Talbot ***@***.***> wrote:
Hey Mitch,
I think I spoke to soon. Found an issue
On Sun, Jul 28, 2024 at 8:08 AM John Talbot ***@***.***> wrote:
> Hey Mitch,
>
> I just published to npm v8.00-beta1. It should be backward compatible to
> your plugin.
>
> Ttyl,
> John
>
> On Sat, Jul 27, 2024 at 11:21 PM John Talbot ***@***.***>
> wrote:
>
>> Hi Mitch,
>>
>> Sio TargetAirQuality and TargetSlatState are now deprecated, this gave
>> a few init problems that I've corrected. the branch b_Ver8 should work
>> though I want to check how docs are created and the example config.json
>> uses them.
>>
>> night,
>> John
>>
>> On Sat, Jul 27, 2024 at 12:05 PM John Talbot ***@***.***>
>> wrote:
>>
>>> Hey Mitch,
>>>
>>> Getting closer. Cmd4 has the latest stuff under b_Ver8. What I found
>>> so far is that the Characteristic type provided by homebridge no longer has
>>> the Formats,Perms & Units sub types. These types must be taken directly
>>> from api.hap. The branch so far fixes these and is backward compatible,
>>> but there is a further issue with valid values. I'll check this later as
>>> that's it for now.
>>>
>>> ttyl,
>>> John
>>>
>>> On Sat, Jul 27, 2024 at 9:10 AM John Talbot ***@***.***>
>>> wrote:
>>>
>>>> Hey Mitch,
>>>>
>>>> Good news, I was able to duplicate your traceback.
>>>>
>>>> ttyl,
>>>> John
>>>>
>>>> On Sat, Jul 27, 2024 at 8:49 AM John Talbot ***@***.***>
>>>> wrote:
>>>>
>>>>> Hi Mitch,
>>>>>
>>>>> Thanks very much for this. It's an odd traceback. It complains
>>>>> about "Characteristic.Formats.BOOL". Characteristics is a passed in type
>>>>> from homebridge. They must have changed it, which is usually a big no no.
>>>>>
>>>>> ttyl,
>>>>> John
>>>>>
>>>>> On Sat, Jul 27, 2024 at 4:04 AM Mitch Williams <
>>>>> ***@***.***> wrote:
>>>>>
>>>>>> @ztalbot2000 <https://github.com/ztalbot2000> I spent a bit more
>>>>>> time trying to collect some logs for you and find some strange behaviour.
>>>>>> It seems the plug-in will fail to initialise altogether, it then removes
>>>>>> itself as a child bridge if it is one and then will refuse to load up again
>>>>>> until a reboot of Homebridge is attempted. Trying to reboot the child
>>>>>> bridge in the plug-ins tab does nothing (I think because it removes itself
>>>>>> as a child bridge). This means it does not cause a Homebridge reboot
>>>>>> seqeunce but does mean the plug-in fails.
>>>>>>
>>>>>> [27/07/2024, 3:57:33 pm] Loaded plugin: ***@***.***
>>>>>> [27/07/2024, 3:57:33 pm] ====================
>>>>>> [27/07/2024, 3:57:33 pm] ERROR INITIALIZING PLUGIN homebridge-cmd4:
>>>>>> [27/07/2024, 3:57:33 pm] TypeError: Cannot read properties of undefined (reading 'BOOL')
>>>>>> at Object.init (/usr/local/lib/node_modules/homebridge-cmd4/lib/CMD4_CHAR_TYPE_ENUMS.js:61:44)
>>>>>> at Plugin.default [as pluginInitializer] (/usr/local/lib/node_modules/homebridge-cmd4/index.js:41:44)
>>>>>> at Plugin.initialize (/usr/local/lib/node_modules/homebridge/src/plugin.ts:244:17)
>>>>>> at PluginManager.initializePlugin (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:173:20)
>>>>>> at PluginManager.initializeInstalledPlugins (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:162:18)
>>>>>> at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:161:5)
>>>>>> [27/07/2024, 3:57:33 pm] ====================
>>>>>> [27/07/2024, 3:57:33 pm] ---
>>>>>>
>>>>>> Let me know if you need me to collect more logs, but will suggest
>>>>>> with the little spare time on my hands currently that you could spin up a
>>>>>> Homebridge instance, install Cmd4, then upgrade Homebridge to the beta and
>>>>>> see what happens.
>>>>>>
>>>>>> —
>>>>>> Reply to this email directly, view it on GitHub
>>>>>> <#146 (comment)>,
>>>>>> or unsubscribe
>>>>>> <https://github.com/notifications/unsubscribe-auth/ABSBCXYKCV4YORI52EDRI5LZONIAJAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGAZDMOJQGY>
>>>>>> .
>>>>>> You are receiving this because you were mentioned.Message ID:
>>>>>> ***@***.***>
>>>>>>
>>>>>
|
|
Hey Mitch,
Just published ***@***.***
There is something seriously wrong with homebridge v2. First there are a
number of device types and characteristics that are now deprecated. These
are mainly Bridge type Accessories and their characteristics.
I've taken care of those by marking them deprecated in my lib files.
The BIG problem I have is that the library files during unit testing are
having memory problems. For example if I print out perms of index 1,
instead of getting "pr", "ev" I get null, "pr"
I'll dig more but I'd like you to give this beta a try.
ttyl,
John
…On Sun, Jul 28, 2024 at 5:40 PM John Talbot ***@***.***> wrote:
Hi Mitch.
P[ublished beta.2. IT runs under homebridge v2, but a lot of tests fail
for bridged devices and also some of my tests check the output of
homebridge and they added messages that I do not account for.
You should give this a go though.
ttyl,
John
On Sun, Jul 28, 2024 at 3:58 PM John Talbot ***@***.***> wrote:
> Hey Mitch,
>
> I think I spoke to soon. Found an issue
>
> On Sun, Jul 28, 2024 at 8:08 AM John Talbot ***@***.***>
> wrote:
>
>> Hey Mitch,
>>
>> I just published to npm v8.00-beta1. It should be backward compatible
>> to your plugin.
>>
>> Ttyl,
>> John
>>
>> On Sat, Jul 27, 2024 at 11:21 PM John Talbot ***@***.***>
>> wrote:
>>
>>> Hi Mitch,
>>>
>>> Sio TargetAirQuality and TargetSlatState are now deprecated, this
>>> gave a few init problems that I've corrected. the branch b_Ver8 should work
>>> though I want to check how docs are created and the example config.json
>>> uses them.
>>>
>>> night,
>>> John
>>>
>>> On Sat, Jul 27, 2024 at 12:05 PM John Talbot ***@***.***>
>>> wrote:
>>>
>>>> Hey Mitch,
>>>>
>>>> Getting closer. Cmd4 has the latest stuff under b_Ver8. What I
>>>> found so far is that the Characteristic type provided by homebridge no
>>>> longer has the Formats,Perms & Units sub types. These types must be taken
>>>> directly from api.hap. The branch so far fixes these and is backward
>>>> compatible, but there is a further issue with valid values. I'll check
>>>> this later as that's it for now.
>>>>
>>>> ttyl,
>>>> John
>>>>
>>>> On Sat, Jul 27, 2024 at 9:10 AM John Talbot ***@***.***>
>>>> wrote:
>>>>
>>>>> Hey Mitch,
>>>>>
>>>>> Good news, I was able to duplicate your traceback.
>>>>>
>>>>> ttyl,
>>>>> John
>>>>>
>>>>> On Sat, Jul 27, 2024 at 8:49 AM John Talbot ***@***.***>
>>>>> wrote:
>>>>>
>>>>>> Hi Mitch,
>>>>>>
>>>>>> Thanks very much for this. It's an odd traceback. It complains
>>>>>> about "Characteristic.Formats.BOOL". Characteristics is a passed in type
>>>>>> from homebridge. They must have changed it, which is usually a big no no.
>>>>>>
>>>>>> ttyl,
>>>>>> John
>>>>>>
>>>>>> On Sat, Jul 27, 2024 at 4:04 AM Mitch Williams <
>>>>>> ***@***.***> wrote:
>>>>>>
>>>>>>> @ztalbot2000 <https://github.com/ztalbot2000> I spent a bit more
>>>>>>> time trying to collect some logs for you and find some strange behaviour.
>>>>>>> It seems the plug-in will fail to initialise altogether, it then removes
>>>>>>> itself as a child bridge if it is one and then will refuse to load up again
>>>>>>> until a reboot of Homebridge is attempted. Trying to reboot the child
>>>>>>> bridge in the plug-ins tab does nothing (I think because it removes itself
>>>>>>> as a child bridge). This means it does not cause a Homebridge reboot
>>>>>>> seqeunce but does mean the plug-in fails.
>>>>>>>
>>>>>>> [27/07/2024, 3:57:33 pm] Loaded plugin: ***@***.***
>>>>>>> [27/07/2024, 3:57:33 pm] ====================
>>>>>>> [27/07/2024, 3:57:33 pm] ERROR INITIALIZING PLUGIN homebridge-cmd4:
>>>>>>> [27/07/2024, 3:57:33 pm] TypeError: Cannot read properties of undefined (reading 'BOOL')
>>>>>>> at Object.init (/usr/local/lib/node_modules/homebridge-cmd4/lib/CMD4_CHAR_TYPE_ENUMS.js:61:44)
>>>>>>> at Plugin.default [as pluginInitializer] (/usr/local/lib/node_modules/homebridge-cmd4/index.js:41:44)
>>>>>>> at Plugin.initialize (/usr/local/lib/node_modules/homebridge/src/plugin.ts:244:17)
>>>>>>> at PluginManager.initializePlugin (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:173:20)
>>>>>>> at PluginManager.initializeInstalledPlugins (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:162:18)
>>>>>>> at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:161:5)
>>>>>>> [27/07/2024, 3:57:33 pm] ====================
>>>>>>> [27/07/2024, 3:57:33 pm] ---
>>>>>>>
>>>>>>> Let me know if you need me to collect more logs, but will suggest
>>>>>>> with the little spare time on my hands currently that you could spin up a
>>>>>>> Homebridge instance, install Cmd4, then upgrade Homebridge to the beta and
>>>>>>> see what happens.
>>>>>>>
>>>>>>> —
>>>>>>> Reply to this email directly, view it on GitHub
>>>>>>> <#146 (comment)>,
>>>>>>> or unsubscribe
>>>>>>> <https://github.com/notifications/unsubscribe-auth/ABSBCXYKCV4YORI52EDRI5LZONIAJAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGAZDMOJQGY>
>>>>>>> .
>>>>>>> You are receiving this because you were mentioned.Message ID:
>>>>>>> ***@***.***>
>>>>>>>
>>>>>>
|
|
Hey John, I can see you have been busy :) just installed the beta on Homebridge I will try to get and test this on Homebridge v2 soon, just need to make sure I am prepared as it destroys my whole home and have to do a restore afterwards which takes a bit of time. |
|
Hey John, looks like Cmd4 The only thing it complains about is the following: Is there an easy way for you to set up all services/charateristics and see which ones complain? As it stands this works perfectly for my AdvAir plug-in, but others might still have warnings like I do for my Hisense TV setup through your plug-in. |
|
Hi Mitch,
Beta 3 works, but beta 4 doesn't. Did I understand you correctly?
If that's correct that's very annoying. I'll check it out.
Ttyl,
John
…On Mon, Jul 29, 2024 at 2:11 AM Mitch Williams ***@***.***> wrote:
Hey John, looks like Cmd4 v8.0.0-beta.3 is working for me on Homebridge
v2 and no more crashing:
[29/07/2024, 2:05:49 pm] [Cmd4] Restarting child bridge...
[29/07/2024, 2:05:49 pm] Got SIGTERM, shutting down child bridge process...
[29/07/2024, 2:05:54 pm] [Cmd4] Child bridge process ended
[29/07/2024, 2:05:54 pm] [Cmd4] Process Ended. Code: 143, Signal: null
[29/07/2024, 2:06:01 pm] [Cmd4] Restarting Process...
[29/07/2024, 2:06:02 pm] [Cmd4] Launched child bridge with PID 20796
[29/07/2024, 2:06:02 pm] Registering accessory 'homebridge-cmd4.Cmd4'
[29/07/2024, 2:06:02 pm] Registering platform 'homebridge-cmd4.Cmd4'
[29/07/2024, 2:06:02 pm] [Cmd4] Loaded homebridge-cmd4 v8.0.0-beta.3 child bridge successfully
[29/07/2024, 2:06:02 pm] Loaded 16 cached accessories from cachedAccessories.0EF085EB9153.
[29/07/2024, 2:06:02 pm] [Cmd4] Cmd4Platform didFinishLaunching
[29/07/2024, 2:06:02 pm] [Cmd4] Restoring existing accessory from cache: Aircon
[29/07/2024, 2:06:05 pm] [Cmd4] Creating linked accessories for: Aircon
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Aircon Fan
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Aircon Timer
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Living Room Zone
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Theater Zone
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Bedroom Zone
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Craft Room Zone
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Guest Room Zone
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Nursery Zone
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Living Room Temperature
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Theater Temperature
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Bedroom Temperature
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Craft Room Temperature
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Guest Room Temperature
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Nursery Temperature
[29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: PS5
[29/07/2024, 2:06:05 pm] [Cmd4] Adding new platformAccessory: Hisense
[29/07/2024, 2:06:05 pm] [Cmd4] Configuring platformAccessory: Hisense
[29/07/2024, 2:06:05 pm] [Cmd4] Creating accessories for: Hisense
[29/07/2024, 2:06:05 pm] [Cmd4] Creating linked accessories for: Hisense
[29/07/2024, 2:06:05 pm] [Cmd4] Cmd4 is running in Demo Mode for TV
[29/07/2024, 2:06:05 pm] [Cmd4] Cmd4 is running in Demo Mode for HDMI1
[29/07/2024, 2:06:05 pm] [Cmd4] Cmd4 is running in Demo Mode for HDMI2
[29/07/2024, 2:06:05 pm] [Cmd4] Cmd4 is running in Demo Mode for HDMI3
[29/07/2024, 2:06:05 pm] [Cmd4] Cmd4 is running in Demo Mode for HDMI4
[29/07/2024, 2:06:05 pm] [Cmd4] Cmd4 is running in Demo Mode for AV
HAP-NodeJS WARNING: The accessory 'My_TelevisionSpeaker' has an invalid 'Name' characteristic ('My_TelevisionSpeaker'). Please use only alphanumeric, space, and apostrophe characters. Ensure it starts and ends with an alphabetic or numeric character, and avoid emojis. This may prevent the accessory from being added in the Home App or cause unresponsiveness.
[29/07/2024, 2:06:05 pm] [Cmd4] Accessory Aircon will be removed.
[29/07/2024, 2:06:05 pm] [Cmd4] Accessory Aircon Fan will be removed.
[29/07/2024, 2:06:05 pm] [Cmd4] Accessory Aircon Timer will be removed.
[29/07/2024, 2:06:05 pm] [Cmd4] Accessory Living Room Zone will be removed.
[29/07/2024, 2:06:05 pm] [Cmd4] Accessory Theater Zone will be removed.
[29/07/2024, 2:06:05 pm] [Cmd4] Accessory Bedroom Zone will be removed.
[29/07/2024, 2:06:05 pm] [Cmd4] Accessory Craft Room Zone will be removed.
[29/07/2024, 2:06:05 pm] [Cmd4] Accessory Guest Room Zone will be removed.
[29/07/2024, 2:06:05 pm] [Cmd4] Accessory Nursery Zone will be removed.
[29/07/2024, 2:06:05 pm] [Cmd4] Accessory Living Room Temperature will be removed.
[29/07/2024, 2:06:05 pm] [Cmd4] Accessory Theater Temperature will be removed.
[29/07/2024, 2:06:05 pm] [Cmd4] Accessory Bedroom Temperature will be removed.
[29/07/2024, 2:06:06 pm] [Cmd4] Accessory Craft Room Temperature will be removed.
[29/07/2024, 2:06:06 pm] [Cmd4] Accessory Guest Room Temperature will be removed.
[29/07/2024, 2:06:06 pm] [Cmd4] Accessory Nursery Temperature will be removed.
[29/07/2024, 2:06:06 pm] [Cmd4] Accessory PS5 will be removed.
[29/07/2024, 2:06:06 pm] Homebridge v1.8.5-beta.4 (HAP v0.12.3-beta.26) (Cmd4) is running on port 46526.
[29/07/2024, 2:06:06 pm]
NOTICE TO USERS AND PLUGIN DEVELOPERS
> Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
> Please visit the following link to learn more about the changes and how to prepare:
> https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0
[29/07/2024, 2:06:06 pm] Hisense E7B5 is running on port 33431.
[29/07/2024, 2:06:06 pm] Please add [Hisense E7B5] manually in Home app. Setup Code: 592-12-550
[29/07/2024, 2:06:46 pm] [Cmd4] *** Starting Polling
[29/07/2024, 2:08:49 pm] [Cmd4] *** All characteristics are now being polled
The only thing it complains about is the following:
HAP-NodeJS WARNING: The accessory 'My_TelevisionSpeaker' has an invalid 'Name' characteristic ('My_TelevisionSpeaker'). Please use only alphanumeric, space, and apostrophe characters. Ensure it starts and ends with an alphabetic or numeric character, and avoid emojis. This may prevent the accessory from being added in the Home App or cause unresponsiveness.
Is there an easy way for you to set up all services/charateristics and see
which ones complain? As it stands this works perfectly for my AdvAir
plug-in, but others might still have warnings like I do for my Hisense TV
setup through your plug-in.
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX7UWNGLIMVNH4452YLZOXMKNAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJVGAZDGMBRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hey Mitch,
As for the My_TelevisionSpeaker, you have to remove the underscore
character "_" in the name. It's not my message but Homebridge's.
Ttyl,
John
…On Mon, Jul 29, 2024 at 7:19 AM John Talbot ***@***.***> wrote:
Hi Mitch,
Beta 3 works, but beta 4 doesn't. Did I understand you correctly?
If that's correct that's very annoying. I'll check it out.
Ttyl,
John
On Mon, Jul 29, 2024 at 2:11 AM Mitch Williams ***@***.***>
wrote:
> Hey John, looks like Cmd4 v8.0.0-beta.3 is working for me on Homebridge
> v2 and no more crashing:
>
>
> [29/07/2024, 2:05:49 pm] [Cmd4] Restarting child bridge...
> [29/07/2024, 2:05:49 pm] Got SIGTERM, shutting down child bridge process...
> [29/07/2024, 2:05:54 pm] [Cmd4] Child bridge process ended
> [29/07/2024, 2:05:54 pm] [Cmd4] Process Ended. Code: 143, Signal: null
> [29/07/2024, 2:06:01 pm] [Cmd4] Restarting Process...
> [29/07/2024, 2:06:02 pm] [Cmd4] Launched child bridge with PID 20796
> [29/07/2024, 2:06:02 pm] Registering accessory 'homebridge-cmd4.Cmd4'
> [29/07/2024, 2:06:02 pm] Registering platform 'homebridge-cmd4.Cmd4'
> [29/07/2024, 2:06:02 pm] [Cmd4] Loaded homebridge-cmd4 v8.0.0-beta.3 child bridge successfully
> [29/07/2024, 2:06:02 pm] Loaded 16 cached accessories from cachedAccessories.0EF085EB9153.
> [29/07/2024, 2:06:02 pm] [Cmd4] Cmd4Platform didFinishLaunching
> [29/07/2024, 2:06:02 pm] [Cmd4] Restoring existing accessory from cache: Aircon
> [29/07/2024, 2:06:05 pm] [Cmd4] Creating linked accessories for: Aircon
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Aircon Fan
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Aircon Timer
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Living Room Zone
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Theater Zone
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Bedroom Zone
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Craft Room Zone
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Guest Room Zone
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Nursery Zone
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Living Room Temperature
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Theater Temperature
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Bedroom Temperature
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Craft Room Temperature
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Guest Room Temperature
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: Nursery Temperature
> [29/07/2024, 2:06:05 pm] [Cmd4] Restoring existing accessory from cache: PS5
> [29/07/2024, 2:06:05 pm] [Cmd4] Adding new platformAccessory: Hisense
> [29/07/2024, 2:06:05 pm] [Cmd4] Configuring platformAccessory: Hisense
> [29/07/2024, 2:06:05 pm] [Cmd4] Creating accessories for: Hisense
> [29/07/2024, 2:06:05 pm] [Cmd4] Creating linked accessories for: Hisense
> [29/07/2024, 2:06:05 pm] [Cmd4] Cmd4 is running in Demo Mode for TV
> [29/07/2024, 2:06:05 pm] [Cmd4] Cmd4 is running in Demo Mode for HDMI1
> [29/07/2024, 2:06:05 pm] [Cmd4] Cmd4 is running in Demo Mode for HDMI2
> [29/07/2024, 2:06:05 pm] [Cmd4] Cmd4 is running in Demo Mode for HDMI3
> [29/07/2024, 2:06:05 pm] [Cmd4] Cmd4 is running in Demo Mode for HDMI4
> [29/07/2024, 2:06:05 pm] [Cmd4] Cmd4 is running in Demo Mode for AV
> HAP-NodeJS WARNING: The accessory 'My_TelevisionSpeaker' has an invalid 'Name' characteristic ('My_TelevisionSpeaker'). Please use only alphanumeric, space, and apostrophe characters. Ensure it starts and ends with an alphabetic or numeric character, and avoid emojis. This may prevent the accessory from being added in the Home App or cause unresponsiveness.
> [29/07/2024, 2:06:05 pm] [Cmd4] Accessory Aircon will be removed.
> [29/07/2024, 2:06:05 pm] [Cmd4] Accessory Aircon Fan will be removed.
> [29/07/2024, 2:06:05 pm] [Cmd4] Accessory Aircon Timer will be removed.
> [29/07/2024, 2:06:05 pm] [Cmd4] Accessory Living Room Zone will be removed.
> [29/07/2024, 2:06:05 pm] [Cmd4] Accessory Theater Zone will be removed.
> [29/07/2024, 2:06:05 pm] [Cmd4] Accessory Bedroom Zone will be removed.
> [29/07/2024, 2:06:05 pm] [Cmd4] Accessory Craft Room Zone will be removed.
> [29/07/2024, 2:06:05 pm] [Cmd4] Accessory Guest Room Zone will be removed.
> [29/07/2024, 2:06:05 pm] [Cmd4] Accessory Nursery Zone will be removed.
> [29/07/2024, 2:06:05 pm] [Cmd4] Accessory Living Room Temperature will be removed.
> [29/07/2024, 2:06:05 pm] [Cmd4] Accessory Theater Temperature will be removed.
> [29/07/2024, 2:06:05 pm] [Cmd4] Accessory Bedroom Temperature will be removed.
> [29/07/2024, 2:06:06 pm] [Cmd4] Accessory Craft Room Temperature will be removed.
> [29/07/2024, 2:06:06 pm] [Cmd4] Accessory Guest Room Temperature will be removed.
> [29/07/2024, 2:06:06 pm] [Cmd4] Accessory Nursery Temperature will be removed.
> [29/07/2024, 2:06:06 pm] [Cmd4] Accessory PS5 will be removed.
> [29/07/2024, 2:06:06 pm] Homebridge v1.8.5-beta.4 (HAP v0.12.3-beta.26) (Cmd4) is running on port 46526.
> [29/07/2024, 2:06:06 pm]
>
> NOTICE TO USERS AND PLUGIN DEVELOPERS
> > Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
> > Please visit the following link to learn more about the changes and how to prepare:
> > https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0
>
> [29/07/2024, 2:06:06 pm] Hisense E7B5 is running on port 33431.
> [29/07/2024, 2:06:06 pm] Please add [Hisense E7B5] manually in Home app. Setup Code: 592-12-550
> [29/07/2024, 2:06:46 pm] [Cmd4] *** Starting Polling
> [29/07/2024, 2:08:49 pm] [Cmd4] *** All characteristics are now being polled
>
> The only thing it complains about is the following:
>
> HAP-NodeJS WARNING: The accessory 'My_TelevisionSpeaker' has an invalid 'Name' characteristic ('My_TelevisionSpeaker'). Please use only alphanumeric, space, and apostrophe characters. Ensure it starts and ends with an alphabetic or numeric character, and avoid emojis. This may prevent the accessory from being added in the Home App or cause unresponsiveness.
>
> Is there an easy way for you to set up all services/charateristics and
> see which ones complain? As it stands this works perfectly for my AdvAir
> plug-in, but others might still have warnings like I do for my Hisense TV
> setup through your plug-in.
>
> —
> Reply to this email directly, view it on GitHub
> <#146 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABSBCX7UWNGLIMVNH4452YLZOXMKNAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJVGAZDGMBRGI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
Hey John, can’t see a beta 4 in your releases, I have only tested beta 3 and it works, only issue is how it removes all my accessories and re-adds them… |
I can see that in my config now as something have I defined (probably copied from your sample config but never changed myself). Didn’t notice this, sorry haha my brain has turned to mush since having the twins… |
|
Hey Mitch,
My brain is fried too. There was no beta 4.
Ttyl,
John
…On Mon, Jul 29, 2024 at 7:27 AM Mitch Williams ***@***.***> wrote:
As for the My_TelevisionSpeaker, you have to remove the underscore
character "_" in the name.
I can see that in my config now as something have I defined (probably
copied from your sample config but never changed myself). Didn’t notice
this, sorry haha my brain has turned to mush since having the twins…
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX4MQIOSBROHWQ6IX2DZOYRLFAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJVGY4DCNRVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I can’t speak for all your users but I would say your changes fix things for my users :) or at least it does for my setup… |
|
Hi Mitch,
So Cmd4 has 11153 test cases. I just submitted beta 4. This fixes a lot
of the test cases that fail in homebridge v2. They changed a lot of perms
from READ to PAIRED_READ. They also obsoleted more devices. BatteryService
for distance changed to Battery. I now have only 48 test cases that fail.
I did notice that when I move from homebridge v1.8 to V2 the deleted
accessory message and the same when I move back to v1.8, This deleted
message does not occur if you run the same version of homebridge
consecutively.
ttyl,
John
…On Mon, Jul 29, 2024 at 7:34 AM Mitch Williams ***@***.***> wrote:
I can’t speak for all your users but I would say your changes fix things
for my users :) or at least it does for my setup…
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX2LKDCSI6A5BVHZ2FLZOYSDBAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJVGY4TGOBWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi Mitch,
Getting closer. Down to 25 failing unit tests. I only use
characteristic.getValue in unit tests and that is deprecated. I'll get to
it tomorrow.
Beta 5 is the one you want to test. It passes get/set in the
priorityPollingQueue. Homebridge V2 removed Perms.READ and Perms.WRITE
which was causing a lot of issues. Fakegato-history was also fixed, but you
don't use that.
ttyl,
John
…On Mon, Jul 29, 2024 at 1:06 PM John Talbot ***@***.***> wrote:
Hi Mitch,
So Cmd4 has 11153 test cases. I just submitted beta 4. This fixes a lot
of the test cases that fail in homebridge v2. They changed a lot of perms
from READ to PAIRED_READ. They also obsoleted more devices. BatteryService
for distance changed to Battery. I now have only 48 test cases that fail.
I did notice that when I move from homebridge v1.8 to V2 the deleted
accessory message and the same when I move back to v1.8, This deleted
message does not occur if you run the same version of homebridge
consecutively.
ttyl,
John
On Mon, Jul 29, 2024 at 7:34 AM Mitch Williams ***@***.***>
wrote:
> I can’t speak for all your users but I would say your changes fix things
> for my users :) or at least it does for my setup…
>
> —
> Reply to this email directly, view it on GitHub
> <#146 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABSBCX2LKDCSI6A5BVHZ2FLZOYSDBAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJVGY4TGOBWG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
Hey John, will give beta 5 a go tomorrow. It kept failing to update for me today, which I have had happen in the past with other plugins and a physical reboot of my RPi fixed it. I was busy testing some other stuff on my RPi today and did not want to have to reboot it just yet; sorry for the hold up! |
|
Hey Mitch,
So beta6 is now available. All unit tests pass. This should be the final
version. I set the package.json to also be V2 compatible as per homebridges
recommendations for V2 required changes.
ttyl,
John
…On Tue, Jul 30, 2024 at 9:11 AM Mitch Williams ***@***.***> wrote:
Hey John, will give beta 5 a go tomorrow. It kept failing to update for me
today, which I have had happen in the past with other plugins and a
physical reboot of my RPi fixed it. I was busy testing some other stuff on
my RPi today and did not want to have to reboot it just yet; sorry for the
hold up!
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCXZIYC7OEIDS2Z5TJTDZO6GJZAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYGMYTQNJSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hey John, just tried the your beta 6 on on Homebridge latest and looks all good. I am about to test on the Homebridge beta but have just now noticed they also have an alpha, which version of theirs should I be testing this on, |
|
Hey Mitch,
1.8.5 is just a fix branch. I thought they were farther along in their
2.0 than alpha. I had just done a git fetch of their latest and assumed it
was their 2.0 beta stuff.
Since you have your own Cmd4MyPlace I guess I don't have to worry about
homebridge beta. No need for you to test Cmd4 either, but thanks anyway.
Ttyl,
John
…On Tue, Jul 30, 2024 at 11:47 PM Mitch Williams ***@***.***> wrote:
Hey John, just tried the your beta 6 on on Homebridge latest and looks all
good. I am about to test on the Homebridge beta but have just now noticed
they also have an alpha, which version of theirs should I be testing this
on, v1.8.5-beta.5 or v2.0.0-alpha.3?
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCXYFKPCFRWHH62TQ4M3ZPBM57AVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJZGU4DONBXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hey John, my plugin |
|
I also don’t understand which is supposed to be the more updated version of theirs, the alpha or the beta? |
|
hey this ploblem also to me. |
|
Hi John, As far as I can understand, what the users have been experiencing is due to the fact that the In place of
then use that JSON array to check which accessories were NOT restored and need to be deleted.
I know this seems like a band aid solution and probably a kludge, but it worked! In any case, I just want to share with you what I did in my spare time for your reference. |
|
My edited version of |
|
Hi Guys,
So I still have not had time to really research this, other than I
believe the Homebridge platform template does not provide this either. I
may get to it soon, but if you think that their code is not backward
compatible, then it might be their issue.
I have had multiple major problems of my own to deal with and won't be
available until next week.
Ttyl,
John
…On Tue, Aug 6, 2024 at 11:34 PM Ung Sing Wong ***@***.***> wrote:
My edited version of Cmd4Platform.js can be found here for your reference:
https://github.com/uswong/homebridge-cmd4/blob/master/Cmd4Platform.js
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX7PNTWEKYACQHXRW33ZQGIUBAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZSGU2DSNRTGE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Hey John, My third attempt to resolve the unintended removal of restored accessories. Since 
This worked well. Cheers, |
|
The modified Cmd4Platform.js with that one additional line of code can be found in: https://github.com/uswong/homebridge-cmd4/blob/master/Cmd4Platform.js @mitch7391, would you please test this out on your system if you have a moment. Thanks. |
|
Thanks Ung Sing, will try to take a look tonight or tomorrow night; we have family from Tassie over to see the twins at the moment :) |
|
@uswong just gave your fix a go and it works for me. We may just need to check if hardcoding a 'true' is something we should permanently do (is there a time where it needs to read a 'false'?). I will keep the changes in for the time being to monitor and see what John comes back with. Going to re-open this issue seen as it is still an issue. |
|
Hey @mitch7391, the added line of code
Hope John can have a moment to have a look at this proposed fix soon. It certainly looks like there are quite a few people having this issue. |
|
Good point Ung Sing, I had looked over the commit change (the before vs after) but a tired brain did not let that sink in properly! Sounds like a win to me, let’s see what John says when he has a moment. |
|
Hi all,
So I did a little check last night. While it says it is being removed.
They are the old stored format. If you wait a minute, you will see polling
begin, so the devices are still there. Running Cmd4 again and you do not
see the removing accessory message.
…On Thu, Aug 15, 2024 at 7:00 AM Ung Sing Wong ***@***.***> wrote:
Hey @mitch7391 <https://github.com/mitch7391>, the added line of code existingAccessory.reachable
= true in *Cmd4Platform.js is* just to replace the deprecated updateReachability(
ture ) . So, it does not do anything more than before.
existingAccessory.reachable is always false with homebridge v1.8 and
always undefined with homebridge v2.0 until we set it to true. If it is
not set to true, all restored accessories will be removed. The function updateReachability(
true ) was used to set it to true with homebridge v1.8 but that function
was deprecated with hombridge v2.0. Therefore we need to set it to true
explicitly with homebridge v2.0. And that is what the proposed fix does.
Hope John can have a moment to have a look at this proposed fix soon. It
certainly looks like there are quite a few people having this issue.
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX5LAVXHAM7PWOQ6H5LZRSC43AVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGA3TIOBXGQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Hi John, if you run Cmd4 the third time, you will see the removing accessory message again.... It does not matter you run Cmd4 in Homebridge 1.8 or 2.0, the behavior is the same. If the accessory is restored from cache, it will always be removed, then the 2nd Cmd4 run will re-create the accessory, then the 3rd run will restore the accessory from cache and immediately will be removed again, and this cycle of Restoring-Removing-Recreating-Restoring-Removing will go on and on.... This behavior persists because the key |
|
Hi Sing,
Do you not think this should be a homebridge bug then?
Ttyl,
John
…On Thu, Aug 15, 2024 at 12:21 PM Ung Sing Wong ***@***.***> wrote:
Hi John,
if you run Cmd4 the third time, you will see the removing accessory
message again.... It does not matter you run Cmd4 in Homebridge 1.8 or 2.0,
the behavior is the same.
If the accessory is restored from cache, it will always be removed, then
the 2nd Cmd4 run will re-create the accessory, then the 3rd run will
restore the accessory from cache and immediately will be removed again, and
this cycle of *Restoring-Removing-Recreating-Restoring-Removing* will go
on and on....
This behavior persists because the key reachable is either false (with
homebrige 1.8) or undefined (with homebridge 2.0). One way to break this
behavior is to set the key reachable to true if the accessory is restored
from cache. And this can be achieved by inserting a line of code after line
474 in Cmd4Platform.js:
existingAccessory.reachable = true;
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX7OHNZ3ZUNQXJ7B7NDZRTIPBAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGY2DAOBZGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Hi John,
I do not think it is a homebridge bug. However, they did deprecat
“updateReachabity()” function, so we will need to replace that with an
explicit code to set the “reachable” to ‘true’ for those accessories
restored from cache. Otherwise, reachable is always false or undefined and
that will trigger the removal of accessory.
…On Fri, 16 Aug 2024 at 00:35 John Talbot ***@***.***> wrote:
Hi Sing,
Do you not think this should be a homebridge bug then?
Ttyl,
John
On Thu, Aug 15, 2024 at 12:21 PM Ung Sing Wong ***@***.***>
wrote:
> Hi John,
>
> if you run Cmd4 the third time, you will see the removing accessory
> message again.... It does not matter you run Cmd4 in Homebridge 1.8 or
2.0,
> the behavior is the same.
>
> If the accessory is restored from cache, it will always be removed, then
> the 2nd Cmd4 run will re-create the accessory, then the 3rd run will
> restore the accessory from cache and immediately will be removed again,
and
> this cycle of *Restoring-Removing-Recreating-Restoring-Removing* will go
> on and on....
>
> This behavior persists because the key reachable is either false (with
> homebrige 1.8) or undefined (with homebridge 2.0). One way to break this
> behavior is to set the key reachable to true if the accessory is
restored
> from cache. And this can be achieved by inserting a line of code after
line
> 474 in Cmd4Platform.js:
> existingAccessory.reachable = true;
>
> —
> Reply to this email directly, view it on GitHub
> <
#146 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABSBCX7OHNZ3ZUNQXJ7B7NDZRTIPBAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGY2DAOBZGY>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXAO6PKUXXJ4RSHL6DGVREDZRTKGRAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGY4DEOJUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hey Sing,
They did deprecate it but if their template does not handle accessories
being restored properly, then all plugins will have this issue and they
have a problem.
Ttyl,
John
On Thu, Aug 15, 2024 at 1:01 PM Ung Sing Wong ***@***.***>
wrote:
… Hi John,
I do not think it is a homebridge bug. However, they did deprecat
“updateReachabity()” function, so we will need to replace that with an
explicit code to set the “reachable” to ‘true’ for those accessories
restored from cache. Otherwise, reachable is always false or undefined and
that will trigger the removal of accessory.
On Fri, 16 Aug 2024 at 00:35 John Talbot ***@***.***> wrote:
> Hi Sing,
>
> Do you not think this should be a homebridge bug then?
>
> Ttyl,
> John
>
> On Thu, Aug 15, 2024 at 12:21 PM Ung Sing Wong ***@***.***>
> wrote:
>
> > Hi John,
> >
> > if you run Cmd4 the third time, you will see the removing accessory
> > message again.... It does not matter you run Cmd4 in Homebridge 1.8 or
> 2.0,
> > the behavior is the same.
> >
> > If the accessory is restored from cache, it will always be removed,
then
> > the 2nd Cmd4 run will re-create the accessory, then the 3rd run will
> > restore the accessory from cache and immediately will be removed
again,
> and
> > this cycle of *Restoring-Removing-Recreating-Restoring-Removing* will
go
> > on and on....
> >
> > This behavior persists because the key reachable is either false (with
> > homebrige 1.8) or undefined (with homebridge 2.0). One way to break
this
> > behavior is to set the key reachable to true if the accessory is
> restored
> > from cache. And this can be achieved by inserting a line of code after
> line
> > 474 in Cmd4Platform.js:
> > existingAccessory.reachable = true;
> >
> > —
> > Reply to this email directly, view it on GitHub
> > <
>
#146 (comment)>,
>
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/ABSBCX7OHNZ3ZUNQXJ7B7NDZRTIPBAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGY2DAOBZGY>
>
> > .
> > You are receiving this because you modified the open/close
state.Message
> > ID: ***@***.***>
> >
>
> —
> Reply to this email directly, view it on GitHub
> <
#146 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AXAO6PKUXXJ4RSHL6DGVREDZRTKGRAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGY4DEOJUG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX5A57TQ2XF73G5ZANTZRTNGFAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRG4ZDGOBVGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Hi,
Weird. It does happen like you said on the third attempt.
We need to take the Homebridge template and prove the same so all plugins
will benefit.
Ttyl,
John
…On Thu, Aug 15, 2024 at 1:46 PM John Talbot ***@***.***> wrote:
Hey Sing,
They did deprecate it but if their template does not handle accessories
being restored properly, then all plugins will have this issue and they
have a problem.
Ttyl,
John
On Thu, Aug 15, 2024 at 1:01 PM Ung Sing Wong ***@***.***>
wrote:
> Hi John,
>
> I do not think it is a homebridge bug. However, they did deprecat
> “updateReachabity()” function, so we will need to replace that with an
> explicit code to set the “reachable” to ‘true’ for those accessories
> restored from cache. Otherwise, reachable is always false or undefined
> and
> that will trigger the removal of accessory.
>
>
> On Fri, 16 Aug 2024 at 00:35 John Talbot ***@***.***> wrote:
>
> > Hi Sing,
> >
> > Do you not think this should be a homebridge bug then?
> >
> > Ttyl,
> > John
> >
> > On Thu, Aug 15, 2024 at 12:21 PM Ung Sing Wong ***@***.***>
> > wrote:
> >
> > > Hi John,
> > >
> > > if you run Cmd4 the third time, you will see the removing accessory
> > > message again.... It does not matter you run Cmd4 in Homebridge 1.8
> or
> > 2.0,
> > > the behavior is the same.
> > >
> > > If the accessory is restored from cache, it will always be removed,
> then
> > > the 2nd Cmd4 run will re-create the accessory, then the 3rd run will
> > > restore the accessory from cache and immediately will be removed
> again,
> > and
> > > this cycle of *Restoring-Removing-Recreating-Restoring-Removing* will
> go
> > > on and on....
> > >
> > > This behavior persists because the key reachable is either false
> (with
> > > homebrige 1.8) or undefined (with homebridge 2.0). One way to break
> this
> > > behavior is to set the key reachable to true if the accessory is
> > restored
> > > from cache. And this can be achieved by inserting a line of code
> after
> > line
> > > 474 in Cmd4Platform.js:
> > > existingAccessory.reachable = true;
> > >
> > > —
> > > Reply to this email directly, view it on GitHub
> > > <
> >
> #146 (comment)>,
>
> >
> > > or unsubscribe
> > > <
> >
> https://github.com/notifications/unsubscribe-auth/ABSBCX7OHNZ3ZUNQXJ7B7NDZRTIPBAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGY2DAOBZGY>
>
> >
> > > .
> > > You are receiving this because you modified the open/close
> state.Message
> > > ID: ***@***.***>
> > >
> >
> > —
> > Reply to this email directly, view it on GitHub
> > <
> #146 (comment)>,
>
> > or unsubscribe
> > <
> https://github.com/notifications/unsubscribe-auth/AXAO6PKUXXJ4RSHL6DGVREDZRTKGRAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGY4DEOJUG4>
>
> > .
> > You are receiving this because you were mentioned.Message ID:
> > ***@***.***>
> >
>
> —
> Reply to this email directly, view it on GitHub
> <#146 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABSBCX5A57TQ2XF73G5ZANTZRTNGFAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRG4ZDGOBVGI>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
|
Hey John, Their latest homebridge template does not include any logic for the removable of existing accessory from cache, it is up to the plugin developer to code the logic. Your existing logic in Cmd4Platform.js is My proposed fix is to add a line of code It works beautifully. Please test it out for yourself. You can find my modified version of Cmd4Platform.js here: |
|
Hi,
I believe you that it would work. According to
https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0 there
is no requirement for plugins to do so. Therefore they need to fix
something. If I can, I will use their template to prove it and submit a bug
on their site. Until they acknowledge the issue, anything we do is
temporary and everyone else's plugins will also suffer.
Ttyl,
John
…On Fri, Aug 16, 2024 at 2:06 AM Ung Sing Wong ***@***.***> wrote:
...they did deprecate it but if their template does not handle accessories
being restored properly, then all plugins will have this issue and they
have a problem.
Hey John,
Their latest homebridge template does not include any *logic* for the
removable of existing accessory from cache, it is up to the plugin
developer to code the logic.
Your existing logic in *Cmd4Platform.js* is if ( ! accessory.reachable )
then remove the existing accessory from cache. By default reachable is
false or undefined. As such, we have to define reachable and set it to
true if that accessory is restored from cache and we do not want it to be
removed.
My proposed fix is to add a line of code existingAccessory.reachable =
true; after line 474 in *Cmd4Platform.js*.
It works beautifully. Please test it out for yourself.
You can find my modified version of *Cmd4Platform.js* here:
https://github.com/uswong/homebridge-cmd4/blob/master/Cmd4Platform.js)
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX3SSKCSQJ4UDPDFOXTZRWJFTAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSHA3TMNRWHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Hi John, Apparently, there is already an issue raised requesting a template on how to remove accessory from cache but homebridge hasn't replied for 2.5 months: homebridge/homebridge-plugin-template#73 In any case, I think it is worthwhile to have a temporary solution for now for your many Cmd4 users. |
|
Hi,
I used their template and ran it a number of times. It does not suffer
from the problem. They do not use reachable. An accessory is found to be
new or old or deleted based on its UUID. Somehow something is different and
I need to check. Unfortunately I must go back to bed. I'll try later.
ttyl,
John
…On Fri, Aug 16, 2024 at 8:39 AM Ung Sing Wong ***@***.***> wrote:
Hi John,
Apparently, there is already an issue raised requesting a template on how
to remove accessory from cache but homebridge hasn't replied for 2.5
months: homebridge/homebridge-plugin-template#73
<homebridge/homebridge-plugin-template#73>
In any case, I think it is worthwhile to have a temporary solution for now
for your many Cmd4 users.
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX3MY47JW7X3W2J4VKDZRXXILAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJTGQZTOMBUG4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Hi all,
So there is something funny. I put a Cmd4 switch as a platform with
their template plugin (Which I called v2Bug). When I ran it against v1.8
and then v2.0 I got the funny behaviour.
[2024-08-16, 11:31:37 a.m.] Loading 3 platforms...
[2024-08-16, 11:31:37 a.m.] [Cmd4] Initializing Cmd4 platform...
[2024-08-16, 11:31:37 a.m.] [v2bug] Initializing v2bug platform...
[2024-08-16, 11:31:37 a.m.] [v2bug] Finished initializing platform: v2bug
[2024-08-16, 11:31:37 a.m.] [Config] Initializing config platform...
[2024-08-16, 11:31:37 a.m.] [Config] Spawning homebridge-config-ui-x with
PID 6418
[2024-08-16, 11:31:37 a.m.] [v2bug] Loading accessory from cache: Bedroom
[2024-08-16, 11:31:37 a.m.] [v2bug] Loading accessory from cache: Kitchen
[2024-08-16, 11:31:37 a.m.] [Cmd4] Cmd4Platform didFinishLaunching
[2024-08-16, 11:31:37 a.m.] [Cmd4] Restoring existing accessory from cache:
PS4
[2024-08-16, 11:31:38 a.m.] [Cmd4] Accessory PS4 will be removed.
[2024-08-16, 11:31:38 a.m.] [v2bug] Executed didFinishLaunching callback
[2024-08-16, 11:31:38 a.m.] [v2bug] Restoring existing accessory from
cache: Bedroom
[2024-08-16, 11:31:38 a.m.] [v2bug] Restoring existing accessory from
cache: Kitchen
Reachable is not the answer as they do not use this in their template.
Something is clearly odd though.
I can only look at this for a few minutes and then must go back to bed.
ttyl,
John
…On Fri, Aug 16, 2024 at 8:56 AM John Talbot ***@***.***> wrote:
Hi,
I used their template and ran it a number of times. It does not suffer
from the problem. They do not use reachable. An accessory is found to be
new or old or deleted based on its UUID. Somehow something is different and
I need to check. Unfortunately I must go back to bed. I'll try later.
ttyl,
John
On Fri, Aug 16, 2024 at 8:39 AM Ung Sing Wong ***@***.***>
wrote:
> Hi John,
>
> Apparently, there is already an issue raised requesting a template on how
> to remove accessory from cache but homebridge hasn't replied for 2.5
> months: homebridge/homebridge-plugin-template#73
> <homebridge/homebridge-plugin-template#73>
>
> In any case, I think it is worthwhile to have a temporary solution for
> now for your many Cmd4 users.
>
> —
> Reply to this email directly, view it on GitHub
> <#146 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABSBCX3MY47JW7X3W2J4VKDZRXXILAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJTGQZTOMBUG4>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
|
|
Closed with homebridge-cmd4 v8.0.1 ttyl, |
|
Hey John, been a hectic few days for us with the twins and family staying; just catching up now…
Ung Sing is completely right here, this is an area of your In your latest version the platform does not remove accessories from the cache and therefore leaves them there as accessories in HomeKit showing ‘no response’, you are then placing it on the user to go to Homebridge settings and individually remove these no longer required accessories using the ‘remove single cached accessory’ option. I do believe if you do not know of a better solution than what Ung Sing has presented, I do think we should go ahead with his proposed solution; as it does work as your plugin used to do before the Homebridge v2 change requirements. |
|
@ztalbot2000 just checking in on you and to let you know this is still an issue... |
|
Hey @ztalbot2000 just checking in again :) |
|
Hi Mitch,
I'll have another look this weekend. I was hoping Homebridge would fix
this issue as they broke it by removing the variable. It should not be the
responsibility of every plugin to do this, but the platforms.
Procrastinating I suppose.
ttyl,
John
…On Fri, Oct 18, 2024 at 5:48 AM Mitch Williams ***@***.***> wrote:
Hey @ztalbot2000 <https://github.com/ztalbot2000> just checking in again
:)
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSBCX2G4WQLLHIKB2UHG23Z4DKPDAVCNFSM6AAAAABLN3PZCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRSGAYDMMZQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hey John, this is not an issue Homebridge are going to fix... Have a look here at the Homebridge Template Plugin platform.ts file Line 34 onward. It is on the plugin developer to create the accessory discovery, adding and removing of accessories; Homebridge itself is only going to handle the caching of these accessories after the fact. All of my plugin users and all Cmd4 users will be experiencing the issue I described above if they are trialing the Homebridge v2 beta or once Homebridge release it properly:
I have had to manually apply Ung Sing's fix way back when he suggested it and avoid updating any further so I do not blow it away. This will be a ticking time bomb for when Homebridge roll out the update and I can guarantee I will have users submit an issue for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe:
Hey @ztalbot2000 I am not sure if you are aware but the next version of Homebridge (v2.0) comes with breaking changes for a lot of Homebridge plug-ins and it has been put on the developers to get in line and update to match.
For Plug-In Developers
I have tested Cmd4 on the beta version and it will crash Homebridge.
Describe the solution you'd like:
Please have a read of the link above and see what changes are required for Cmd4, this will ultimately affect my plug-in as well.
Describe alternatives you've considered:
All users of Cmd4 will have to remain on Homebridge v1.8.4.
Additional context:
The text was updated successfully, but these errors were encountered: