Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] zulip_bots does not include importlib-metadata as a dependency on Python>=3.10 but tries to import it regardless of version #829

Open
cauebs opened this issue Sep 3, 2024 · 2 comments
Assignees

Comments

@cauebs
Copy link

cauebs commented Sep 3, 2024

Running on Python 3.10:

  File ".../zulip_bots/finder.py", line 11, in <module>

    import importlib_metadata as metadata
ModuleNotFoundError: No module named 'importlib_metadata'

Solution is to either always include importlib-metadata as a dependency in zulip_bots/setup.py, independently of the Python version, or do a conditional import checking for the Python version and using std's importlib.metadata instead of importlib_metadata for Python>=3.10.

Whichever the maintainers decide, I can file a pull request for it.

@hr1shu
Copy link

hr1shu commented Nov 20, 2024

Hi @cauebs @timabbott , Can I work on this issue?

@timabbott
Copy link
Member

Yep, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants