Android: Bump compileSdkVersion from 31 to 34 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
force-pushed
the
pr-compile-sdk-version-34
branch
from
a844880
to
49a4821
Compare
The Java changes in a recent commit won't be picked up in zulip-mobile unless we build React Native from source; discussion: zulip/zulip-mobile#5892 (comment) After those Java changes, though, some new constants are read (`Context.RECEIVER_EXPORTED` and `Context.RECEIVER_NOT_EXPORTED`). To get those, we need compileSdkVersion >= 34.
chrisbobbe
force-pushed
the
pr-compile-sdk-version-34
branch
from
49a4821
to
b7b2f6c
Compare
|
Updated following an over-the-shoulder review in the office; PTAL. 🙂 |
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java changes in a recent commit won't be picked up in
zulip-mobile unless we build React Native from source; discussion:
zulip/zulip-mobile#5892 (comment)
After those Java changes, though, some new constants are read
(
Context.RECEIVER_EXPORTEDandContext.RECEIVER_NOT_EXPORTED).To get those, we need compileSdkVersion >= 34.