Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle new/empty direct message narrows better #1480

Closed
Niloth-p opened this issue Apr 14, 2024 · 4 comments
Closed

Handle new/empty direct message narrows better #1480

Niloth-p opened this issue Apr 14, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Niloth-p
Copy link
Collaborator

On opening DM narrows with a new user (someone you haven't previously had a private conversation with),

@Niloth-p Niloth-p changed the title Hande new/empty direct message narrows better Handle new/empty direct message narrows better Apr 14, 2024
@Niloth-p
Copy link
Collaborator Author

@zulipbot add "bug"

@zulipbot zulipbot added the bug Something isn't working label Apr 14, 2024
@neiljp
Copy link
Collaborator

neiljp commented Apr 18, 2024

@Niloth-p Thanks for filing this, though I believe this is essentially a DM-specific case of #607, both of which really apply to any empty narrow? For example, no starred messages, no mentions, and an empty search is likely the easiest to replicate.

I'm not sure how this is related to #1343 ?

Exiting from this situation is certainly a problem in general, though the a hotkey case is possibly a separate bug where it only triggers in certain UI locations. It'd certainly be useful to track down if that is the case.

@Niloth-p
Copy link
Collaborator Author

Thank you for the good suggestions on the replication part, I failed to consider an empty search.
Since these points weren't reported there, I wasn't sure if it was the same.

I didn't realise that the 'a' hotkey is a separate bug.
It's currently set to trigger only when focused on a MessageBox. So, I thought that was associated with the narrow being empty.
I've looked into adding support for the 'a' hotkey throughout the window.
Should I edit and re-frame this issue to the 'all messages' command?

@neiljp
Copy link
Collaborator

neiljp commented Apr 22, 2024

@Niloth-p If there's no obvious issue for the a hotkey issue, please do open a separate one for that point - you can reference the discussion in the stream too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants