Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as Zupit i want to change the libraries prefix to follow the official angular documentation convention #31

Open
deyan-koba-zupit opened this issue May 27, 2024 · 1 comment · May be fixed by #32
Labels
task Small bodies of work that are not directly related to the users needs

Comments

@deyan-koba-zupit
Copy link
Contributor

Currently, we have three libraries that use the ng- prefix (ng-form, ng-auth and ng-fantasticon). According to the official Angular documentation, we should rename this prefix to ngx- as ng- is a reserved keyword and the ngx- prefix is preferred as a convention used to denote that the library is suitable for use with Angular

@deyan-koba-zupit deyan-koba-zupit changed the title change libraries prefix as Zupit i want to change the libraries prefix to follow the official angular documentation convention May 27, 2024
@deyan-koba-zupit deyan-koba-zupit added the task Small bodies of work that are not directly related to the users needs label May 27, 2024
@omar-muscatello-zupit
Copy link
Contributor

Since we are at the beginning of the project and we have just a few libraries, it's ok for me to proceed with renaming the current libraries (with a low priority task).

For new libraries, we can immediatelly use the ngx- prefix.

@alessandro-mariotti-zupit what do you think?

@deyan-koba-zupit deyan-koba-zupit linked a pull request Jun 9, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Small bodies of work that are not directly related to the users needs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants