Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] - Add examples to test suite #18

Open
EmanueleGhelfi opened this issue Jul 26, 2019 · 4 comments
Open

[FEATURE] - Add examples to test suite #18

EmanueleGhelfi opened this issue Jul 26, 2019 · 4 comments
Assignees
@iLeW @galeone @mr-ubik @EmanueleGhelfi
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@EmanueleGhelfi
Copy link
Contributor

System information

  • AshPy version (you are using): 1.0.2
  • Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state
Currently examples are not tested. We can think to add examples in the test suite or in a separate stage of travis in order to check that every example still work after some changes.

Will this change the current api? How?
We need to change the travis.yml configuration.

Who will benefit with this feature?
Everyone.
@EmanueleGhelfi EmanueleGhelfi added enhancement New feature or request question Further information is requested labels Jul 26, 2019
@mr-ubik
Copy link
Contributor

mr-ubik commented Jul 26, 2019

Do examples cover API alredady not in a doctest?

@mr-ubik
Copy link
Contributor

mr-ubik commented Jan 21, 2020

Bump for greater glory

@mr-ubik mr-ubik added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 29, 2020
@EmanueleGhelfi
Copy link
Contributor Author

Ping

@EmanueleGhelfi
Copy link
Contributor Author

I think this is an issue as currently our examples are not working due to minor issues with Path library and usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iLeW iLeW

@galeone galeone

@mr-ubik mr-ubik

@EmanueleGhelfi EmanueleGhelfi

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iLeW @galeone @mr-ubik @EmanueleGhelfi