Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control view for chain's mixer controls #1276

Open
riban-bw opened this issue Nov 7, 2024 · 3 comments
Open

Control view for chain's mixer controls #1276

riban-bw opened this issue Nov 7, 2024 · 3 comments
Assignees
Labels
Enhancement New feature or request
Milestone

Comments

@riban-bw
Copy link

riban-bw commented Nov 7, 2024

Is your feature request related to a problem? Please describe.
The mixer view offers access to some of the audio mixer's controls, e.g. fader, mute, solo, pan but not all of them and it may be challenging to perform some operations, e.g. binding MIDI CC, fine control, etc.

Describe the solution you'd like
For each chain that fees the audio mixer (audio, synth, etc.) provide control pages so that the control view can be opened and each parameter accessed. This should be at the end of the control pages or maybe at the fader postion, i.e. between pre and post fader processors' control pages.

Describe alternatives you've considered
The mixer has improved touch control and MIDI learning but it may be further enhanced with this request.

Additional context
We may need to present the mixer as a processor or multiple processors.

@riban-bw
Copy link
Author

I am working on this and will soon create a dev branch for this development. It allows each mixer strip to be added to the zynmixer engine as a separate processor. These processors appear in the chain so can be moved around like any other processor although I think we should keep them in their own slots, i.e. not have a mixer strip in parallel with any other effect. This simplifies the logical design and implementation. I have split the mixer into two jack clients with the input channels in one and the mixbuses in the other which reduces latency for post-fader effects chains.

@riban-bw riban-bw self-assigned this Nov 12, 2024
@riban-bw riban-bw added the Enhancement New feature or request label Nov 12, 2024
@riban-bw riban-bw added this to the Vangelis milestone Nov 12, 2024
riban-bw pushed a commit to zynthian/zynthian-ui that referenced this issue Nov 13, 2024
Splits zynmixer in half with input channels and mixbuses seperated to reduce latency.
Adds arbitrary quantity of effects send/returns.
Adds mixer processor to each audio chain which may be moved up/down the chain.
All mixer controls appear in control view allowing simple and consistent MIDI learn.
Removed MIDI learn from mixer view.
Effects return chains are MIDI + Audio.
@riban-bw
Copy link
Author

I have pushed the dev branch to GitHub but it needs more work. It is working as a proof-of-concept but there will be many bugs and issues that need resolving.

@riban-bw
Copy link
Author

This is now fully implemented in dev branch. There may be some validation to be done with controller device drivers but I've implemented most required changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant