Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag for skipping universal patterns. #16

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Add a flag for skipping universal patterns. #16

merged 4 commits into from
Apr 12, 2024

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Apr 9, 2024

No description provided.

@wRAR wRAR mentioned this pull request Apr 9, 2024
Merged
4 tasks
BurnzZ
BurnzZ reviewed Apr 9, 2024
View reviewed changes
tests/test_matcher.py Show resolved Hide resolved
url_matcher/matcher.py Show resolved Hide resolved
BurnzZ
BurnzZ approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@BurnzZ BurnzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a small test to be added, LGTM!

url_matcher/matcher.py Show resolved Hide resolved
@wRAR wRAR merged commit c39f11b into main Apr 12, 2024
10 checks passed
@wRAR wRAR deleted the skip-domainless branch April 12, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmike kmike kmike approved these changes

@BurnzZ BurnzZ BurnzZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wRAR @kmike @BurnzZ