Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remaining Shang-Chi in DB #244

Open
mmougy opened this issue Aug 10, 2024 · 5 comments
Open

remaining Shang-Chi in DB #244

mmougy opened this issue Aug 10, 2024 · 5 comments

Comments

@mmougy
Copy link

mmougy commented Aug 10, 2024 •
edited
Loading

they are 2 card "Shang-Chi" referenced in the database, but they represent the same card from Taskmaster's set.

In marvelsdb-json-data repo, there is only one Shang-Chi (04098, the encounter one)
I don't understand where does Shang-Chi 10098 comes from

find Shang-Chi
image

Shang-Chi 04098
this is the correct one (because referenced as encounter card, and exists in marvelsdb-json-data repo)
image

Shang-Chi 10098
this is the wrong one (because referenced as hero card, and does not exists in marvelsdb-json-data repo)
image
@mmougy mmougy mentioned this issue Nov 23, 2024
Open
@mmougy
Copy link
Author

mmougy commented Dec 3, 2024

It seems icons are displayed on some cards but shouldn't
some data remains in db, even if they are removed from marvelsdb-json-data

see #251 (comment)

@mmougy
Copy link
Author

mmougy commented Jan 8, 2025 •
edited
Loading

Night of the Sentinels - 32087a works fine
but it seems Night of the Sentinels - 32087 is still alive, and shouldn't. it messes with search page and pagination

We did recently some changes in marvelsdb-json-data for main schemes:
for example: 32087 -> 32087a & 32087b

after some test, it seems that the command php bin/console app:import:std path-to-marvelsdb-json-data/ only add/update rows in db.
If a card code is updated, a new row is created, but the previous row is not deleted

A purge of card tables before importing marvelsdb-json-data should solve this.
@Kamalisk I can create a dedicated command if needed

--

Night of the Sentinels - 32087a
image
Night of the Sentinels - 32087 old data: stage and text issues
image

@Kamalisk
Copy link
Collaborator

Kamalisk commented Jan 10, 2025 •
edited
Loading

generally the import is intentionally not meant to remove data, as it causes issues with decks that use the cards, and has to remove connected data, and reconnect those to cards in decks. Not to mention it has no way of knowing if its a new card or a card with a changed code. I usually just manually remove cards which have been added incorrectly.

@mmougy
Copy link
Author

mmougy commented Jan 10, 2025

Ok, let me know if I can help.
Maybe updating somewhere a list of cards to remove?

@mmougy
Copy link
Author

mmougy commented Jan 16, 2025 •
edited
Loading

@Kamalisk , here is a list of cards that should be removed because a version "xxxxxa" exists (or for some reason the code has been updated like Shang-Chi)

all seems fine here.

all seems fine here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kamalisk @mmougy