Refactor distrbiuteProfit #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bin-57blocks
commented
Dec 30, 2023
bin-57blocks
commented
- Update distProfitToTranches to include first loss cover profits
- Move distLossToTranches and distLossRecoveryToTranches out to pool
Fix a bug Fix failed tests Move distLossToTranches and distLossRecoveryToTranches from policy to pool
|
ljiatu
approved these changes
Dec 30, 2023
| for (uint256 i = 0; i < covers.length; i++) { | ||
| if (covers[i] != address(0)) { | ||
| _firstLossCovers.push(IFirstLossCover(covers[i])); | ||
| } else break; |
There was a problem hiding this comment.
nit: why not put this into the termination condition i.e. i < cover.length && covers[i] != address(0)?
| } | ||
| } | ||
|
|
||
| function _distributeProfitForSeniorTranche( |
There was a problem hiding this comment.
nit: I would name this _distProfitToSeniorTranche to be consistent.
| ) | ||
| external | ||
| returns ( | ||
| uint256[2] memory profitsForTrancheVault, |
| * @param juniorTotalAssets the total asset amount for junior tranche | ||
| * @custom:access Internal function without access restriction. Caller needs to control access | ||
| */ | ||
| function _calcProfitForFirstLossCovers( |
There was a problem hiding this comment.
Call this _distProditToFirstLossCovers to be consistent?
| @@ -11,25 +11,23 @@ import {SENIOR_TRANCHE, JUNIOR_TRANCHE, HUNDRED_PERCENT_IN_BPS} from "./SharedDe | |||
| */ | |||
| contract RiskAdjustedTranchesPolicy is BaseTranchesPolicy { | |||
| /** | |||
| * @notice Distributes profit between tranches. | |||
| * @dev Ignores solhint warning, it can't be view function because it implements ITranchesPolicy's disProfitToTranches. | |||
There was a problem hiding this comment.
This comment is no longer accurate, is it?
wisdant
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.