Add invariant tests #461
Open
Add invariant tests #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bin-57blocks
force-pushed
the
add-invariant-tests
branch
from
dbf13c1 to
3104b75
Compare
bin-57blocks
force-pushed
the
add-invariant-tests
branch
from
82bae10 to
4115c70
Compare
ljiatu
reviewed
Feb 20, 2024
| seniorTranche.addApprovedLender(initLender, true); | ||
| vm.stopPrank(); | ||
|
|
||
| // A lender deposits some liquidity in senior tranche to solve a tiny issue of epoch close |
| // ); | ||
| } | ||
|
|
||
| function _createLenders(uint256 lenderNum) internal { |
There was a problem hiding this comment.
nit: numLenders is much more common.
| for (uint256 i; i < lenderNum; i++) { | ||
| address lender = makeAddr(string(abi.encode("lender", i))); | ||
| vm.startPrank(poolOperator); | ||
| bool reinvesting = i % 2 == 0 ? true : false; |
There was a problem hiding this comment.
nit: can we just do bool reinvesting = i % 2 == 0?
| } | ||
| } | ||
|
|
||
| function _createBorrowers(uint256 borrowerNum) internal { |
| @@ -0,0 +1,43 @@ | |||
| async function main() { | |||
| const input = `sender=0x0000000000000000000000000000000a17B60033 addr=[test/invariant/handlers/LiquidityHandler.sol:LiquidityHandler]0x65c26fC57D9847cF8dF2E4ee0bf45D79cd86Ad96 calldata=withdrawProtocolFee(uint256,uint256) args=[6295442937 [6.295e9], 18189 [1.818e4]] | |||
| names[selector] = name; | ||
| } | ||
|
|
||
| function increaselogCall(bytes4 selector) public returns (uint256) { |
| import {PoolConfig} from "contracts/common/PoolConfig.sol"; | ||
|
|
||
| contract PoolFactoryForTest is PoolFactory { | ||
| function addPoolOwner(uint256 _poolId, address poolOwner) public { |
| @@ -19,7 +19,7 @@ contract ReceivableTest is StdInvariant, Test { | |||
| assertEq(receivableHandler.receivable().totalSupply(), 1); | |||
| } | |||
|
|
|||
| function invariant_supplyEqualsHandlerCount() public { | |||
| function invariant_Receivable_supplyEqualsHandlerCount() public { | |||
There was a problem hiding this comment.
Should we make the name of this function consistent with other invariants?
| _setUp( | ||
| PoolDeployParameters({ | ||
| tranchesPolicyType: FIXED_SENIOR_YIELD_TRANCHES_POLICY, | ||
| // tranchesPolicyType: RISK_ADJUSTED_TRANCHES_POLICY, |
There was a problem hiding this comment.
nit: delete commented out code?
| mapping(uint256 => address[]) investedLendersByTranche; | ||
| mapping(uint256 => address[]) redeemedLendersByTranche; | ||
|
|
||
| constructor(address[] memory _lenders) BaseHandler() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to Huma Invariant Tests and Huma Invariants