Merge pull request #85 from 00labs/fix-upscale

Fix upscale to handle overflow
00labs · Nov 21, 2023 · 89c34c5 · 89c34c5
2 parents a6fe4a6 + 8485c51
commit 89c34c5
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/packages/huma-shared/src/utils/number.ts b/packages/huma-shared/src/utils/number.ts
@@ -67,7 +67,7 @@ export const upScale = <T = string>(
     return num as T
   }
   const result = BigNumber.isBigNumber(num)
-    ? num.mul(10 ** decimals!)
+    ? num.mul(BigNumber.from(10).pow(decimals!))
     : Number(num) * 10 ** decimals!
   if (typeof num === 'string') {
     return String(result) as T

diff --git a/packages/huma-shared/src/utils/pool.ts b/packages/huma-shared/src/utils/pool.ts
@@ -514,6 +514,8 @@ export const PoolContractMap: PoolContractMapType = {
           abi: HDT_ABI,
         },
         extra: {
+          borrower: '0xea57a8a51377752ffddaa3db4d13ce8f97677f2d',
+          rwrUploader: '0xea57a8a51377752ffddaa3db4d13ce8f97677f2d',
           disableBorrow: true,
           detailsPage: true,
         },

diff --git a/packages/huma-shared/tests/utils/number.test.ts b/packages/huma-shared/tests/utils/number.test.ts
@@ -63,6 +63,14 @@ describe('upScale', () => {
     expect(upScale('123.45', 2)).toBe('12345')
     expect(upScale(123.45, 2)).toBe(12345)
   })
+
+  it('returns the upscaled number if the input is a valid number and decimals would cause overflow', () => {
+    expect(
+      upScale<BigNumber>(BigNumber.from(10), 18).eq(
+        BigNumber.from('10000000000000000000'),
+      ),
+    ).toBe(true)
+  })
 })
 
 describe('toBigNumber', () => {