Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrapper classes #311

Merged
merged 9 commits into from
Dec 29, 2023
Merged

Add wrapper classes #311

merged 9 commits into from
Dec 29, 2023

Conversation

05nelsonm
Copy link
Owner

@05nelsonm 05nelsonm commented Dec 28, 2023 •
edited
Loading

Closes #272
Closes #309

@05nelsonm 05nelsonm self-assigned this Dec 28, 2023
05nelsonm
05nelsonm commented Dec 29, 2023
View reviewed changes
Copy link
Owner Author

@05nelsonm 05nelsonm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs:

  • documentation, at least on static to* functions in order to explain accepted formats (URL, base encoding, etc.)
  • Failure tests
  • Key.Private encoded alteration tests

...ntime-api/src/commonMain/kotlin/io/matthewnelson/kmp/tor/runtime/api/address/ProxyAddress.kt Show resolved Hide resolved
...me-api/src/commonTest/kotlin/io/matthewnelson/kmp/tor/runtime/api/key/AuthKeyBaseUnitTest.kt Outdated Show resolved Hide resolved
library/runtime-api/src/commonMain/kotlin/io/matthewnelson/kmp/tor/runtime/api/key/Key.kt Show resolved Hide resolved
@05nelsonm
Copy link
Owner Author

Needs:

  • documentation, at least on static to* functions in order to explain accepted formats (URL, base encoding, etc.)
  • Failure tests
  • Key.Private encoded alteration tests
  • Documentation: Resolved in commit 35c024c
  • Failure Tests: Resolved in commit a329719
  • Key.Private alteration tests: Resolved in commit fdedbfc

05nelsonm
05nelsonm commented Dec 29, 2023
View reviewed changes
Copy link
Owner Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@05nelsonm 05nelsonm merged commit 5bd3d88 into master Dec 29, 2023
6 checks passed
@05nelsonm 05nelsonm deleted the issue/309-wrapper-classes branch December 29, 2023 11:49
@05nelsonm 05nelsonm linked an issue Dec 29, 2023 that may be closed by this pull request
Add wrapper classes #309
Closed
@05nelsonm 05nelsonm mentioned this pull request Jan 1, 2024
Closed
@05nelsonm 05nelsonm linked an issue Jan 4, 2024 that may be closed by this pull request
Remove all SealedValueClass usage #272
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@05nelsonm 05nelsonm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add wrapper classes Remove all SealedValueClass usage
1 participant
@05nelsonm