Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight black border on left and right hand sides of the screen #64

Open
drojf opened this issue Mar 31, 2021 · 3 comments
Open

Slight black border on left and right hand sides of the screen #64

drojf opened this issue Mar 31, 2021 · 3 comments

Comments

@drojf
Copy link
Contributor

drojf commented Mar 31, 2021

Our mod has always had these 1-2 pixel borders on the left and right hand sides of the screen. Normally it's hard to see because it's black, but in certain cases, like a black image which is meant to cover a CG, it can result in the CG showing where the borders would be. Users usually report this happening on Onikakushi as it's the first time they see the graphical glitch.

The unmodded game does not have this issue.

@TellowKrinkle suggested it was a rounding issue, I'll look into that first when I (eventually) have a look at the issue:

Probably a rounding issue somewhere
I bet we (int) things, and with floating point error it might go over or under the target, causing - 1 pixel vs not - 1 pixel
Try setting the aspect ratio to 0.65251 or something and see if that fixes it

modded:
image

unmodded:
image

@drojf
Copy link
Contributor Author

drojf commented Sep 5, 2021

A user reported that when the 'invert colors' effect is applied, there is a white bar at the left and right of screen. I'm pretty sure this is just the black borders in this issue, but the colors are inverted so they become white and more noticeable:

Just played the first chapter of Tsumihoroboshi on linux and found a couple of minor graphical bugs that occurred more than once during the chapter. Every time the colours are inverted, white bars appear on the left and right edges of the screen.

Honeyview_SPOILER_ss-21-09-04_12-01_58

@drojf
Copy link
Contributor Author

drojf commented Mar 4, 2023

Another similar issue on the Onikakushi eyecatch

Honeyview_image (4)

@drojf
Copy link
Contributor Author

drojf commented Mar 22, 2024

Just a note that this issue is more apparent (which causes it to look like it appears/disappears) if there is a bright object in that position.

For example, when this portrait sprite is drawn it is very apparent

image

But when the sprite is removed, you can't really see it

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant