Fix OG mode sprite rotation and offset choice buttons #87

drojf · 2022-09-18T01:19:26Z

This PR fixes some bugs in OG mode (4:3 mode):

In OG mode, when sprites are rotated, they are cropped incorrectly. This PR forces sprites not to be rotated when in 4:3 mode.
- I wouldn't fix it this way if we used rotated sprites all the time, but since we only rotate sprites 1 or 2 times throughout the whole series, this is a sufficient fix.
- See Rotated sprites don't render properly when using 4:3 backgrounds / sprite cropping #72
In OG mode, the choice buttons are not centered - this makes sure they are centered in both 4:3 and 16:9 mode
- See OG mode artset switching issues thread #57

- Currently the method used to clip sprites to the 4:3 window doesn't work with rotation - As there are only 2 places across all the games where this issue happens, we just disable character rotation in those scenes rather than trying to fix it properly - This should only affect images from the `sprite` or `portrait` folder

drojf added 2 commits February 2, 2022 14:06

Fix offset choice button text in 4:3 mode (#57)

31996c0

drojf merged commit 914dcc1 into mod Sep 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix OG mode sprite rotation and offset choice buttons #87

Fix OG mode sprite rotation and offset choice buttons #87

drojf commented Sep 18, 2022

Fix OG mode sprite rotation and offset choice buttons #87

Fix OG mode sprite rotation and offset choice buttons #87

Conversation

drojf commented Sep 18, 2022