-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux gnome crash workaround #91
base: mod
Are you sure you want to change the base?
Conversation
- This commit shouldn't change any behavior, only refactor function calls - This is in preparation to simplify the number of different ways the game changes resolution and windowed/fullscreen modes
a5e7fa1
to
bdb860b
Compare
- NOTE: most of this time, this value is never used, and the res defaults to 1280x720
fd52ed6
to
ed983fa
Compare
@TellowKrinkle reported that this resolution bug only happens on the 64-bit version of the game - the 32-bit version is unaffected. For me to run the 32-bit version of the game on Manjaro (based on Arch Linux)I needed to install:
I think I'll keep the recovery menu/first time linux windowed mode setup menu, but add a note on the first-time setup to run the 32 bit version / link to the wiki with instructions on how to run the 32-bit version, if you have problems with crashes. Should also update the fullscreen-lock button hover-over with this information. |
More info from discord:
|
Note: this PR is superceeded by #93 (assuming all goes well) However, there may be a couple commits I want to keep from this pR, so please don't close this PR yet |
This option adds a workaround for the "Linux Gnome Windowed Mode Crash" bug
For info on the Linux Gnome Windowed Mode Crash bug, see:
This PR does not fix crashing when entering Windowed mode, but makes sure that you can't get the game stuck in a state where it won't launch anymore due to being in Windowed mode (it should recover and enter fullscreen mode). The main things this PR does is:
I've primarily tested on Windows and Manjaro Linux (The system which a user had reported these issues), but I should probably re-test Ubuntu to see if I have broken anything. Some of the changes I made are locked to Linux, to avoid changing working behavior on Windows, but the refactoring and stuff is across all OS's, so that could break things.