Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: admin_getFileLocation; test: sync test #141

Merged
merged 5 commits into from
Jul 23, 2024
Merged

fix: admin_getFileLocation; test: sync test #141

merged 5 commits into from
Jul 23, 2024

Conversation

MiniFrenchBread
Copy link
Contributor

@MiniFrenchBread MiniFrenchBread commented Jul 22, 2024 •
edited by sparkmiw
Loading

  • In sync test, shutdown the client2 during file upload to trigger FindFile in the following sync process

This change is Reviewable

@MiniFrenchBread MiniFrenchBread requested a review from boqiu July 22, 2024 10:17
ChenxingLi
ChenxingLi approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ChenxingLi ChenxingLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @boqiu)

@MiniFrenchBread MiniFrenchBread merged commit 533bacb into main Jul 23, 2024
7 checks passed
@MiniFrenchBread MiniFrenchBread deleted the get_file_location branch July 23, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenxingLi ChenxingLi ChenxingLi approved these changes

@boqiu boqiu Awaiting requested review from boqiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiniFrenchBread @ChenxingLi