Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: surrealdb integration #280

Merged
merged 15 commits into from
Feb 24, 2025
Merged

feat: surrealdb integration #280

merged 15 commits into from
Feb 24, 2025

Conversation

joshua-mo-143
Copy link
Contributor

@joshua-mo-143 joshua-mo-143 commented Feb 7, 2025 •
edited
Loading

Stage one of #269

I couldn't find a way to store the documents better, so for now it's raw JSON strings.

@cvauclair cvauclair added this to the 2025-02-24 milestone Feb 10, 2025
@mateobelanger mateobelanger added the vector store Integration of new vector stores label Feb 18, 2025
0xMochan
0xMochan approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@0xMochan 0xMochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, I need to test locally still but i made a couple of comments

0xMochan
0xMochan approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@0xMochan 0xMochan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested, works flawlessly, just needs a quick rebase.

@joshua-mo-143 joshua-mo-143 merged commit 8229c08 into 0xPlaygrounds:main Feb 24, 2025
5 checks passed
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xMochan 0xMochan 0xMochan approved these changes

Assignees
No one assigned
Labels
non-breaking vector store Integration of new vector stores
Projects
None yet
Milestone
2025-02-24
Development

Successfully merging this pull request may close these issues.
4 participants
@joshua-mo-143 @0xMochan @cvauclair @mateobelanger