feat: add ollama client #285
Merged
+1,017
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xMochan
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Hey, thanks for this PR. I want to clarify that our current ollama example serves both local and remote clients for ollama, using the openai compatibility layer, but ofc, it would be best to use the native ollama api as you've done here.
Please let me know if you have any questions about the comments I've made, thanks!
0xMochan
approved these changes
Feb 18, 2025
0xMochan
requested changes
Feb 18, 2025
|
Thank you! I forgot to remove this From trait. I have added some examples that I used locally to test the Ollama client during development. |
0xMochan
approved these changes
Feb 24, 2025
0xMochan
approved these changes
Feb 24, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR aims to address #288 by adding support for local model execution. Currently, the project only supports remote model inference, while local inference (e.g., using Ollama) offers advantages such as faster response times, enhanced data privacy, and greater control over execution.
Major Changes
Clientstruct: Encapsulates API calls to the Ollama local model server.Code Structure
Key Files
src/providers/ollama.rs: Implements the Ollama API client.