feat: Huggingface provider integration #321
Open
+1,428
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xMochan
requested changes
Feb 25, 2025
| self | ||
| } | ||
|
|
||
| pub fn sub_provider(mut self, provider: SubProvider) -> Self { |
There was a problem hiding this comment.
Suggested change
| pub fn sub_provider(mut self, provider: SubProvider) -> Self { | |
| pub fn sub_provider(mut self, provider: impl Into<SubProvider>) -> Self { |
This makes it convenient to pass custom strings, though you still have to create impl From<&str> since FromStr is different 😭.
| Custom(String), | ||
| } | ||
|
|
||
| impl FromStr for SubProvider { |
There was a problem hiding this comment.
btw, FromStr != From<&str> unfortuntely
| } | ||
|
|
||
| pub fn build(self) -> Client { | ||
| let route = match self.sub_provider.clone() { |
There was a problem hiding this comment.
I would implement ToString for SubProvider here so it's consistent with the enum, then you can use that directly
| let mut request = self.create_request_body(&completion_request)?; | ||
|
|
||
| // Enable streaming | ||
| merge_inplace(&mut request, json!({"stream": true})); |
There was a problem hiding this comment.
This is nice, I think our other streaming stuff could leverage this pattern in a more standardized / trait way (like in #320)
| // } | ||
| // _ => panic!("Expected user message"), | ||
| // } | ||
| } |
There was a problem hiding this comment.
Should this still be commented?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Huggingface models.
Closes #36.