Fix stateroot mismatch bug during resequencing #1754
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyrinCode
requested review from
revitteth,
hexoscott,
mandrigin and
eduadiez
as code owners
|
We require contributors/corporates @KyrinCode to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
|
@KyrinCode please sign commits. Rebase on zkevm of your PRs will also allow unwind tests to pass :) |
KyrinCode
force-pushed
the
kyrin/fix-resequence-mismatch
branch
from
d21cbc3 to
e1b7eef
Compare
KyrinCode
force-pushed
the
kyrin/fix-resequence-mismatch
branch
from
e1b7eef to
fcd1579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1740
Original resequencing logic is to get l1infoupdateindex from datastream and use this index to get corresponding l1infoupdate. However, when replaying mainnet data from X Layer mainnet, I found that the index->ger is not consistent in datastream and hermezdb. As long as there is a l1info update, a mismatch will occur. I think the inconsistency itself is also a bug of implementation, but here I just use ger to get l1infoupdate from hermezdb instead.