Add read batches with concurrency to datastream server #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyrinCode
requested review from
revitteth,
hexoscott,
mandrigin and
eduadiez
as code owners
|
We require contributors/corporates @KyrinCode to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
1 similar comment
|
We require contributors/corporates @KyrinCode to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
|
Hey @KyrinCode looks like we have one commit not signed here which will block us taking this. |
Thanks, I think now things going fine. |
|
@KyrinCode please sign all commits :) |
revitteth
approved these changes
Feb 25, 2025
KyrinCode
force-pushed
the
kyrin/add-read-batches-with-concurrency-to-datastream-server
branch
from
51790f1 to
a9e1ede
Compare
😢 Sorry, I'm not familiar with this. I added gpg sig to these PRs, hope it works fine now. |
…datastream-server
…datastream-server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
ReadBatchesindata_stream_server.gois sequential and we need to wait quite a long time before resequencing. I add a new functionReadBatchesWithConcurrencywhich decrease the time from 467s to 165s (65%) when reading 300 stress test batches from datastream. It actually can be used to replace the existing oneReadBatches(), if you thought it ok.