-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: monitoring guide #699
Conversation
97baab7
to
5b28123
Compare
5b28123
to
b6b1ff3
Compare
b6b1ff3
to
bd11bdd
Compare
Yes, I think markdown is fine - probably for both developers and operators. We can always transform it into something else. In fact, we could do the same thing as we do in
Yes, I don't think we are using this any more - but @Dominik1999 and @phklive can confirm.
Good idea! I think we should do the same in other repos. @PhilippGackstatter, @igamigo - could you do this as well in |
There was no |
What about the other files removed by this PR (e.g., |
Yes, just pushed a PR to remove those: 0xPolygonMiden/miden-client#737 |
Yes we do not use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left some comments inline - mostly small things.
As I mentioned in one of the previous comments, we'd probably want to set this up as mdBook as that's what we are doing in other repos - but this should go into a different PR.
Overall, I'm thinking we should work toward the following structure:
.
├── Introduction
│ ├── Overview
│ ├── Get started
│ └── FAQ
├── Operator guide
│ ├── Installation
│ ├── Configuraton
│ ├── Usage
│ ├── Monitoring
│ └── Updating
├── RPC documentation
└── Developer guide
├── Overview
├── Monitoring
└── [more sections in the future]
ccd5414
to
594d249
Compare
594d249
to
bf9bb30
Compare
Adds monitoring documentation for both operators and node developers.
I'm using markdown to document things. I think for developer documentation this makes a lot of sense since they're going to be working in-repo. This makes less sense for operators, but I think for now its the content that's important; we can always move it to a formal site.
I removed the existing
mkdocs
scripts and references - I don't believe this is used? I also removed editor config (should be covered byrustfmt
unless for some reason you don't use an LSP..), and the pre-commit configuration - once again covered by lints, fmt etc.Closes #680.