Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: monitoring guide #699

Merged
merged 8 commits into from
Feb 20, 2025
Merged

docs: monitoring guide #699

merged 8 commits into from
Feb 20, 2025

Conversation

Mirko-von-Leipzig
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig commented Feb 17, 2025

Adds monitoring documentation for both operators and node developers.

⚠️ I've also removed a bunch of scripts and configuration files which I believe are unused.


I'm using markdown to document things. I think for developer documentation this makes a lot of sense since they're going to be working in-repo. This makes less sense for operators, but I think for now its the content that's important; we can always move it to a formal site.

I removed the existing mkdocs scripts and references - I don't believe this is used? I also removed editor config (should be covered by rustfmt unless for some reason you don't use an LSP..), and the pre-commit configuration - once again covered by lints, fmt etc.


Closes #680.

@Mirko-von-Leipzig Mirko-von-Leipzig force-pushed the mirko/otel-docs branch 2 times, most recently from 97baab7 to 5b28123 Compare February 17, 2025 10:50
@Mirko-von-Leipzig Mirko-von-Leipzig changed the title docs: monitoring guide [wip] docs: monitoring guide Feb 17, 2025
@Mirko-von-Leipzig Mirko-von-Leipzig marked this pull request as ready for review February 17, 2025 15:06
@bobbinth
Copy link
Contributor

I'm using markdown to document things. I think for developer documentation this makes a lot of sense since they're going to be working in-repo. This makes less sense for operators, but I think for now its the content that's important; we can always move it to a formal site.

Yes, I think markdown is fine - probably for both developers and operators. We can always transform it into something else. In fact, we could do the same thing as we do in miden-vm and miden-docs - i.e., set up mdBook to render the docs as a Gighub page.

I removed the existing mkdocs scripts and references - I don't believe this is used?

Yes, I don't think we are using this any more - but @Dominik1999 and @phklive can confirm.

I also removed editor config (should be covered by rustfmt unless for some reason you don't use an LSP..), and the pre-commit configuration - once again covered by lints, fmt etc.

Good idea! I think we should do the same in other repos. @PhilippGackstatter, @igamigo - could you do this as well in miden-base and miden-client respectively?

@igamigo
Copy link
Collaborator

igamigo commented Feb 17, 2025

Good idea! I think we should do the same in other repos. @PhilippGackstatter, @igamigo - could you do this as well in miden-base and miden-client respectively?

There was no .editorconfig in miden-client (not 100% sure but I don't think there ever was one).

@bobbinth
Copy link
Contributor

There was no .editorconfig in miden-client (not 100% sure but I don't think there ever was one).

What about the other files removed by this PR (e.g., docs_requirements.txt, serve-doc-site.sh etc.)?

@igamigo
Copy link
Collaborator

igamigo commented Feb 17, 2025

Yes, just pushed a PR to remove those: 0xPolygonMiden/miden-client#737

@phklive
Copy link
Contributor

phklive commented Feb 17, 2025

I removed the existing mkdocs scripts and references - I don't believe this is used?

Yes, I don't think we are using this any more - but @Dominik1999 and @phklive can confirm.

Yes we do not use mkdocs anymore

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left some comments inline - mostly small things.

As I mentioned in one of the previous comments, we'd probably want to set this up as mdBook as that's what we are doing in other repos - but this should go into a different PR.

Overall, I'm thinking we should work toward the following structure:

.
├── Introduction
│   ├── Overview
│   ├── Get started
│   └── FAQ
├── Operator guide
│   ├── Installation
│   ├── Configuraton
│   ├── Usage
│   ├── Monitoring
│   └── Updating
├── RPC documentation
└── Developer guide
    ├── Overview
    ├── Monitoring
    └── [more sections in the future]

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/dev/monitoring.md Show resolved Hide resolved
docs/dev/monitoring.md Outdated Show resolved Hide resolved
docs/operator.md Show resolved Hide resolved
docs/operator.md Show resolved Hide resolved
@Mirko-von-Leipzig Mirko-von-Leipzig merged commit cf87d34 into next Feb 20, 2025
10 checks passed
@Mirko-von-Leipzig Mirko-von-Leipzig deleted the mirko/otel-docs branch February 20, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants