-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to cairo-lang/Starknet 0.11.2; support scarb #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabijanC
force-pushed
the
adapt-0.11.2
branch
4 times, most recently
from
June 16, 2023 15:14
39793ca
to
70e0111
Compare
FabijanC
changed the title
Adapt to cairo-lang/Starknet 0.11.2
Adapt to cairo-lang/Starknet 0.11.2; add scarb
Jun 16, 2023
* cairo-lang to v0.11.2 * starknet-devnet to v0.5.3 * cairo compiler to v1.1.0
* leave the TODO for build refator
FabijanC
changed the title
Adapt to cairo-lang/Starknet 0.11.2; add scarb
Adapt to cairo-lang/Starknet 0.11.2; support scarb
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
starknet-build
starknet.scarbCommand
in hardhat config file, or via--scarb-command
in the CLIsierra
andcasm
set totrue
under[[target.starknet-contract]]
<PACKAGE_NAME>_<CONTRACT_NAME>
, so they can be loaded withstarknet.getContractFactory("MyPackage_MyContract")
;starknet-compile
command as it was (useful for single Cairo 1 file compilation)Development related changes
@iarna/toml
- for Scarb.toml validationtest/configuration-tests/disallow-cairo1BinDir-when-dockerized
as it was not valid (not a typescript thing, but our validation was making it invalid).cp -a
withfs.cpSync
Checklist:
test
directory (with a test case consisting ofnetwork.json
,hardhat.config.ts
,check.ts
)plugin
branch ofstarknet-hardhat-example
:test.sh
to use my example repo branchtest.sh
to to use the original branch (after the example repo PR has been merged)