Code

Recover constraint debugging#1756

Code

Draft

matthiasgoergens wants to merge 94 commits intomain0xmozak/mozak-vm:mainfrom matthias/recover-constraint-debugging0xmozak/mozak-vm:matthias/recover-constraint-debuggingCopy head branch name to clipboard

+1,051-1,560

Commits

Commits on May 31, 2024

• Revert "Remove counter-productive 'debug' option (#1547)"

  Show description for 84250bd
  matthiasgoergens

  committed
  84250bd

  Copy full SHA for 84250bd

• Introduce new trait

  matthiasgoergens

  committed
  b1a937e

  Copy full SHA for b1a937e

• Lifetime shenanigans

  matthiasgoergens

  committed
  0f6e437

  Copy full SHA for 0f6e437

• Introduce more

  matthiasgoergens

  committed
  e453c64

  Copy full SHA for e453c64

• Remove unnecessary lifetime

  matthiasgoergens

  committed
  7d42524

  Copy full SHA for 7d42524

• Fix lifetimes

  matthiasgoergens

  committed
  bdb5838

  Copy full SHA for bdb5838

• More conversion

  matthiasgoergens

  committed
  d8581ea

  Copy full SHA for d8581ea

• No vars

  matthiasgoergens

  committed
  59d0808

  Copy full SHA for 59d0808

• Inline vars

  matthiasgoergens

  committed
  986d1cc

  Copy full SHA for 986d1cc

• Minimize diff

  matthiasgoergens

  committed
  e3b6ed5

  Copy full SHA for e3b6ed5

• Convert more

  matthiasgoergens

  committed
  fe43ff1

  Copy full SHA for fe43ff1

• Fix

  matthiasgoergens

  committed
  0062e8e

  Copy full SHA for 0062e8e

• Simpler

  matthiasgoergens

  committed
  3a8eb3c

  Copy full SHA for 3a8eb3c

• More uniform

  matthiasgoergens

  committed
  109ae4a

  Copy full SHA for 109ae4a

• Simplify

  matthiasgoergens

  committed
  3960271

  Copy full SHA for 3960271

• Fmt

  matthiasgoergens

  committed
  f724f1c

  Copy full SHA for f724f1c

• Convert more

  matthiasgoergens

  committed
  548026b

  Copy full SHA for 548026b

• Poseidon convert

  matthiasgoergens

  committed
  08ddd98

  Copy full SHA for 08ddd98

• Forward

  matthiasgoergens

  committed
  7d128b3

  Copy full SHA for 7d128b3

• More

  matthiasgoergens

  committed
  bfbdf9a

  Copy full SHA for bfbdf9a

• Commitment

  matthiasgoergens

  committed
  71222b2

  Copy full SHA for 71222b2

• Convert all

  matthiasgoergens

  committed
  cea92e2

  Copy full SHA for cea92e2

• PublicInputs

  matthiasgoergens

  committed
  839a8b8

  Copy full SHA for 839a8b8

• Stopgop

  matthiasgoergens

  committed
  e9c7559

  Copy full SHA for e9c7559

• Remove PublicInputs from HasNamedColumns

  matthiasgoergens

  committed
  f36f903

  Copy full SHA for f36f903

Commits on Jun 3, 2024

• Merge remote-tracking branch 'origin/main' into matthias/recover-constraint-debugging

  matthiasgoergens

  committed
  d427924

  Copy full SHA for d427924

Commits on Jun 5, 2024

• Merge remote-tracking branch 'origin/main' into matthias/recover-constraint-debugging

  matthiasgoergens

  committed
  e062d97

  Copy full SHA for e062d97

• Fix

  matthiasgoergens

  committed
  4ff65b1

  Copy full SHA for 4ff65b1

Commits on Jun 10, 2024

• Merge remote-tracking branch 'origin/main' into matthias/recover-constraint-debugging

  matthiasgoergens

  committed
  84f64d1

  Copy full SHA for 84f64d1

• Try using Expr<'a, T> instead of U in NoColumns

  

  Jakub Zalewski

  committed
  d58eef6

  Copy full SHA for d58eef6

• Move PublicInputs to a GAT

  

  Jakub Zalewski

  committed
  11bac0c

  Copy full SHA for 11bac0c

• Move View to a GAT

  

  Jakub Zalewski

  committed
  5bf4795

  Copy full SHA for 5bf4795

Commits on Jun 11, 2024

• Relax to_typed_starkframe

  

  Jakub Zalewski

  committed
  585aa7b

  Copy full SHA for 585aa7b

• Add FromIterator to GenerateConstraint's GATs

  

  Jakub Zalewski

  committed
  8a8b500

  Copy full SHA for 8a8b500

• Fix type of PublicInputs

  

  Jakub Zalewski

  committed
  67697a0

  Copy full SHA for 67697a0

• Revert "Fix type of PublicInputs"

  Show description for 57dc0ea
  

  Jakub Zalewski

  committed
  57dc0ea

  Copy full SHA for 57dc0ea

• Add a helper function to skip StarkFrame

  

  Jakub Zalewski

  committed
  5250921

  Copy full SHA for 5250921

• Fix Unstark

  

  Jakub Zalewski

  committed
  88bb433

  Copy full SHA for 88bb433

• Add Debug requirement to GenerateConstraints

  

  Jakub Zalewski

  committed
  1fe6ac7

  Copy full SHA for 1fe6ac7

• Add Debug to GenerateConstraints::View

  

  Jakub Zalewski

  committed
  1daef17

  Copy full SHA for 1daef17

• Remove debugging code from expr

  

  Jakub Zalewski

  committed
  ec55208

  Copy full SHA for ec55208

• Make location and term public

  

  Jakub Zalewski

  committed
  d2f8960

  Copy full SHA for d2f8960

• Fix build_debug to just evaluate

  

  Jakub Zalewski

  committed
  1450845

  Copy full SHA for 1450845

• Finish debug_single_trace

  

  Jakub Zalewski

  committed
  4fee3db

  Copy full SHA for 4fee3db

• Fix indentation

  

  Jakub Zalewski

  committed
  340425b

  Copy full SHA for 340425b

• Whoops

  

  Jakub Zalewski

  committed
  cfd544c

  Copy full SHA for cfd544c

Commits on Jun 12, 2024

• Make ConstraintType public

  

  Jakub Zalewski

  committed
  681fc12

  Copy full SHA for 681fc12

• Handle FromIterator when Column is empty

  Show description for c68459c
  

  Jakub Zalewski

  committed
  c68459c

  Copy full SHA for c68459c

• Filter out when constraints are applicable

  

  Jakub Zalewski

  committed
  7c2296e

  Copy full SHA for 7c2296e

Commits on Jun 13, 2024

• cargo clippy

  

  Jakub Zalewski

  committed
  d9f3652

  Copy full SHA for d9f3652

• cargo fmt

  

  Jakub Zalewski

  committed
  702a64f

  Copy full SHA for 702a64f

• Fix Display instance for Unstark

  Show description for 88c6b6d
  

  Jakub Zalewski

  committed
  88c6b6d

  Copy full SHA for 88c6b6d

• cargo fmt

  

  Jakub Zalewski

  committed
  0199021

  Copy full SHA for 0199021

• Another cargo fmt

  

  Jakub Zalewski

  committed
  5b83f11

  Copy full SHA for 5b83f11

• Merge branch 'main' into matthias/recover-constraint-debugging

  

  Jakub Zalewski

  authored
  6f862ab

  Copy full SHA for 6f862ab

• Simplify instances

  

  Jakub Zalewski

  committed
  7deefcd

  Copy full SHA for 7deefcd

Commits on Jun 18, 2024

• Generalise NoColumns to ShadowColumns

  Show description for 40a4d37
  

  Jakub Zalewski

  committed
  40a4d37

  Copy full SHA for 40a4d37

• cargo fmt

  

  Jakub Zalewski

  committed
  0800ac3

  Copy full SHA for 0800ac3

• cargo clippy

  Show description for 68eb2f0
  

  Jakub Zalewski

  committed
  68eb2f0

  Copy full SHA for 68eb2f0

Commits on Jun 19, 2024

• Merge remote-tracking branch 'origin/main' into matthias/recover-constraint-debugging

  matthiasgoergens

  committed
  0188f8c

  Copy full SHA for 0188f8c

• Merge remote-tracking branch 'origin/main' into matthias/recover-constraint-debugging

  matthiasgoergens

  committed
  8c6b983

  Copy full SHA for 8c6b983

• Minimise diff

  matthiasgoergens

  committed
  05eeaf4

  Copy full SHA for 05eeaf4

• Default to no constraints

  matthiasgoergens

  committed
  340c708

  Copy full SHA for 340c708

• Simplify the implementation of StarkFrameTyped

  

  Jakub Zalewski

  committed
  a2e0bff

  Copy full SHA for a2e0bff

Commits on Jun 20, 2024

• Merge remote-tracking branch 'origin/matthias/recover-constraint-debugging' into matthias/recover-constraint-debugging-simplify

  matthiasgoergens

  committed
  d70bca3

  Copy full SHA for d70bca3

• [no ci] WIP and BROKEN

  

  Jakub Zalewski

  committed
  93ad4c7

  Copy full SHA for 93ad4c7

Commits on Jun 21, 2024

• Merge branch 'matthias/recover-constraint-debugging' into matthias/recover-constraint-debugging-simplify

  matthiasgoergens

  committed
  7b2f8c2

  Copy full SHA for 7b2f8c2

• Format

  matthiasgoergens

  committed
  9ddbd37

  Copy full SHA for 9ddbd37

• Merge branch 'matthias/recover-constraint-debugging' into matthias/recover-constraint-debugging-simplify

  matthiasgoergens

  committed
  e428b17

  Copy full SHA for e428b17

• Replace qualified path with 'use'

  matthiasgoergens

  committed
  2cfbab1

  Copy full SHA for 2cfbab1

• Revert

  matthiasgoergens

  committed
  8f4d442

  Copy full SHA for 8f4d442

• Format

  matthiasgoergens

  committed
  595a85c

  Copy full SHA for 595a85c

• Simplify

  matthiasgoergens

  committed
  0c46b6d

  Copy full SHA for 0c46b6d

• Restore

  matthiasgoergens

  committed
  587beb0

  Copy full SHA for 587beb0

• Simplify

  matthiasgoergens

  committed
  c0ad81c

  Copy full SHA for c0ad81c

• Fix

  matthiasgoergens

  committed
  7c78c97

  Copy full SHA for 7c78c97

• Simplify

  matthiasgoergens

  committed
  fd2cc3b

  Copy full SHA for fd2cc3b

• Convert skeleton CPU

  matthiasgoergens

  committed
  cfaeb71

  Copy full SHA for cfaeb71

• Convert CPU

  matthiasgoergens

  committed
  d16a030

  Copy full SHA for d16a030

• Convert full word memory

  matthiasgoergens

  committed
  f40123d

  Copy full SHA for f40123d

• Simplify

  matthiasgoergens

  committed
  7064b4e

  Copy full SHA for 7064b4e

• Convert more

  matthiasgoergens

  committed
  0cb369c

  Copy full SHA for 0cb369c

• Working version

  

  Jakub Zalewski

  committed
  22493b7

  Copy full SHA for 22493b7

• cargo fmt

  

  Jakub Zalewski

  committed
  e3dcd5e

  Copy full SHA for e3dcd5e

• Migrate Unstark to a StarkFrom

  

  Jakub Zalewski

  committed
  bc62799

  Copy full SHA for bc62799

• Remove HasNamedColumns

  

  Jakub Zalewski

  committed
  07bbbca

  Copy full SHA for 07bbbca

• Match directly on StarkFrom

  

  Jakub Zalewski

  committed
  c2bad47

  Copy full SHA for c2bad47

• Remove passthrough to G from StarkFrom

  

  Jakub Zalewski

  committed
  715e41d

  Copy full SHA for 715e41d

Commits on Jul 1, 2024

• Inline Unstark

  

  Jakub Zalewski

  committed
  ebc1c29

  Copy full SHA for ebc1c29

• Remove all the unecessary code

  

  Jakub Zalewski

  committed
  b67f8ee

  Copy full SHA for b67f8ee

• Refactor common structure to an unstark macro

  

  Jakub Zalewski

  committed
  051c9a3

  Copy full SHA for 051c9a3

• cargo clippy

  

  Jakub Zalewski

  committed
  ff0652b

  Copy full SHA for ff0652b

• Merge branch 'main' into matthias/recover-constraint-debugging

  

  Jakub Zalewski

  committed
  4b32868

  Copy full SHA for 4b32868

Commits on Jul 3, 2024

• Clean up convenience type aliases

  

  Jakub Zalewski

  committed
  0f4c6f2

  Copy full SHA for 0f4c6f2