Sync upstream #109
Merged
Sync upstream #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xPolygonZero#1587) * Make select_proof_with_pis public * Add API methods for dummy segment removal * Change visibility of dummy_circuit * Return actual verifier data * Fix Clippy * Apply comments --------- Co-authored-by: Hamy Ratoanina <[email protected]>
Since `std` doesn't exist as a cfg, `not(std)` was always true, so this does not change any behavior.
Not all `correct` cross table lookups use padding for the last row.
…#1599) * Add Field::shifted_powers and iterator niceties * Remove comment
0xPolygonZero#1600) * add batch starks * fix build * fix ci * address comments from hratoanina * address comments from Nashtare * fix tests * address comments from hratoanina * Update plonky2/src/batch_fri/recursive_verifier.rs Co-authored-by: Robin Salen <[email protected]> * Update plonky2/src/hash/merkle_proofs.rs Co-authored-by: Robin Salen <[email protected]> * Update plonky2/src/batch_fri/verifier.rs Co-authored-by: Robin Salen <[email protected]> --------- Co-authored-by: Robin Salen <[email protected]>
matthiasgoergens
approved these changes
Jul 16, 2024
matthiasgoergens
approved these changes
Jul 16, 2024
sai-deng
added a commit
that referenced
this pull request
Jul 18, 2024
Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Hamy Ratoanina <[email protected]> Co-authored-by: Daniel-Aaron-Bloom <[email protected]> Co-authored-by: nuno <[email protected]> Co-authored-by: Matthias Görgens <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Gio <[email protected]> Co-authored-by: Robin Salen <[email protected]>
sai-deng
added a commit
that referenced
this pull request
Jul 18, 2024
Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Hamy Ratoanina <[email protected]> Co-authored-by: Daniel-Aaron-Bloom <[email protected]> Co-authored-by: nuno <[email protected]> Co-authored-by: Matthias Görgens <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Gio <[email protected]> Co-authored-by: Robin Salen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.