Restrict CORS for Builder Secret Keys #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechVitek
force-pushed
the
restrict-cors-for-builder-secret-keys
branch
from
cd2f6b3 to
f692ffa
Compare
VojtechVitek
force-pushed
the
restrict-cors-for-builder-secret-keys
branch
from
f692ffa to
592dec4
Compare
VojtechVitek
commented
Dec 10, 2024
Comment on lines
+216
to
+229
| origin := r.Header.Get("Origin") | ||
| if origin != "" { | ||
| err := proto.ErrSecretKeyCorsDisallowed.WithCausef("project_id: %v", projectClaim) | ||
|
|
||
| slog.ErrorContext(ctx, "CORS disallowed for Secret Key", | ||
| slog.Any("error", err), | ||
| slog.String("origin", origin), | ||
| slog.Uint64("project_id", uint64(projectClaim)), | ||
| ) | ||
|
|
||
| // TODO: Uncomment once we're confident it won't disrupt major customers. | ||
| // cfg.ErrHandler(r, w, err) | ||
| // return | ||
| } |
There was a problem hiding this comment.
For now, this will only log error with origin and project_id fields, if we encounter a Secret Key misused from a web app.
Eventually, we will error out instead, once we're confident it won't disrupt major customers.
klaidliadon
approved these changes
Dec 11, 2024
|
Works fine in node-gateway:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/0xsequence/issue-tracker/issues/3787
Related: https://github.com/0xsequence/issue-tracker/issues/3802