S2S token, S2S client, errors #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-littlefarmer
force-pushed
the
s2s_client_token
branch
from
83b0f41 to
cb1f212
Compare
Comment on lines
+84
to
86
| if cfg == nil { | ||
| return "" | ||
| } |
There was a problem hiding this comment.
return "" doesn't feel right
how about we make the cfg a non-pointer? and call it TokenClaims?
There was a problem hiding this comment.
I suggest (string, bool)
There was a problem hiding this comment.
It panics, when it is nil
When the JWTSecret is empty, then it will return "" in the end.
I added validate function, which checks JWTSecret.
Best would be, if this function can return error.
david-littlefarmer
force-pushed
the
s2s_client_token
branch
from
bd7a5d1 to
acee775
Compare
|
Too many changes. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.