Lootbox contract #23
Merged
Lootbox contract #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScreamingHawk
requested changes
Dec 9, 2024
ScreamingHawk
requested changes
Dec 10, 2024
ScreamingHawk
requested changes
Dec 15, 2024
ScreamingHawk
approved these changes
Dec 16, 2024
PhABC
reviewed
Dec 18, 2024
| event Commit(address user, uint256 blockNumber); | ||
| event Commit(address indexed user, uint256 blockNumber); |
There was a problem hiding this comment.
Let's not index events. It costs more gas and doesn't give any benefit on our indexer since we filter on data.
| import {IERC1155ItemsFunctions} from "@0xsequence/contracts-library/tokens/ERC1155/presets/items/IERC1155Items.sol"; | ||
|
|
||
| contract ERC1155Lootbox is ERC1155Items, IERC1155Lootbox { | ||
| bytes32 internal constant MINT_ADMIN_ROLE = keccak256("MINT_ADMIN_ROLE"); |
There was a problem hiding this comment.
Can we rename this to LOOTBOX_ADMIN_ROLE?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/0xsequence/issue-tracker/issues/3767