-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contracts #4
contracts #4
Conversation
src/tokens/ERC1155/ERC1155Sale.sol
Outdated
* @param _tokenIds Token IDs to mint. | ||
* @param _amounts Amounts of tokens to mint. | ||
*/ | ||
function _payForActiveMint(uint256[] memory _tokenIds, uint256[] memory _amounts) private { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need the ability to add a mint limit per token ID. Should be optional, i.e. if limit is 0, then there is no limit, otherwise it's the limit specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that per transaction / wallet? There is a supply cap limit per token already
make sure metadata output is included in forge build
Current PR state: This is missing the ERC-1155 Packed implementation. I believe it will be trivial to add and would like to have the current contract reviewed/audited first to reduce any re-work.
Depends on 0xsequence/erc-1155#100