intents: add new contractCall transaction type #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pkieltyka
commented
Sep 26, 2024
pkieltyka
commented
- deprecate "delayedEncode" transaction type as its a confusing name, but we leave it to maintain backwards compat
- introduce name "contractCall" transaction type
- new "contractCall" has a bit of sugar so you don't have to pass "func" name if the "abi" field is just a function
- we remove named args support, as it feels unnecessary and confusing
- "value" is optional, and will default to "0"
pkieltyka
commented
Sep 26, 2024
| // And it must always return it encoded, like this: | ||
| // - transferFrom(address,address,uint256) | ||
| // making sure that the method matches the returned one | ||
| func getMethodFromAbi(abi string, method string) (string, []string, error) { |
There was a problem hiding this comment.
this code was moved, its still used
| "1000000000000000000", | ||
| "[\"0x8541D65829f98f7D71A4655cCD7B2bB8494673bF\"]", | ||
| { | ||
| "abi": "notExpired(uint256,string)", |
There was a problem hiding this comment.
the nested encoding is cool.. but what is very confusing, and maybe is actually completely invalid, is the "notExpired(uint256,string)" function name..? the encoder will actually include the "notExpired" name, is that intended..? or do we just want "(uint256,string)" for the encoding without including the method selector into the encoding..?
patrislav
reviewed
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.