Remove extra slash in blockexporer url #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,7 +82,7 @@ export const TransactionStatus = () => { | |||
| onError | |||
| } = transactionStatusSettings! | |||
| const networkConfig = findSupportedNetwork(chainId) | |||
| const blockExplorerUrl = `${networkConfig?.blockExplorer?.rootUrl}/tx/${txHash}` | |||
| const blockExplorerUrl = `${networkConfig?.blockExplorer?.rootUrl}tx/${txHash}` | |||
There was a problem hiding this comment.
I think I'd expect rootUrl not to have the trailing slash. And this path would stay the same /txt/..
There was a problem hiding this comment.
I agree, that it shouldn't be there... But removing it is a breaking change that will break a bunch of applications
There was a problem hiding this comment.
We should create a small pathJoin utility to handle these cases then we don't need to care
There was a problem hiding this comment.
export function join(...paths: string[]): string {
return paths
.map(path => path.trim())
.filter(Boolean)
.join('/')
.replace(/(?<!:)\/{2,}/g, '/')
}
SamueleA
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rootUrl already contains an ending
/