Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Package Exports #51

Merged
merged 7 commits into from
May 15, 2024
Merged

Refine Package Exports #51

merged 7 commits into from
May 15, 2024

Conversation

corbanbrook
Copy link
Collaborator

@corbanbrook corbanbrook commented May 15, 2024

This is general export cleanup to explicitly specify what is exported to create more of a self documenting code base and prepare for future package bundle changes (esm exports)

  • Remove barrel files eg. index.ts files that export * from './somefile'
  • explicitly exports from root index of each package just what is needed by other packages or exposed to userland

@corbanbrook corbanbrook requested a review from SamueleA May 15, 2024 19:36
@corbanbrook corbanbrook marked this pull request as ready for review May 15, 2024 20:40
Copy link
Contributor

@SamueleA SamueleA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corbanbrook corbanbrook merged commit ed07708 into master May 15, 2024
1 check passed
@corbanbrook corbanbrook deleted the refine-exports branch May 15, 2024 21:00
github-actions bot pushed a commit that referenced this pull request May 15, 2024
* Move TxnDetails into KitProvider dir

* packages/kit: Remove barrel files and place explicit exports in root index

* Fixing imports

* package/connectors: Remove barrel file and explicity export each connector and types

* packages/wallet: Only export KitWalletProvider and openWalletModal hook

* packages/checkout: Exporting KitCheckoutProvider and openCheckoutModal

* Export CheckoutSettings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants