Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace react context by valtio #56

Closed
wants to merge 4 commits into from
Closed

Conversation

SamueleA
Copy link
Contributor

@SamueleA SamueleA commented May 16, 2024

TODO: add valtio for kit checkout

@SamueleA SamueleA changed the title removed context from kit package replace react context by valtio May 16, 2024
@pkieltyka
Copy link
Member

please lets not add valito..

@SamueleA
Copy link
Contributor Author

please lets not add valito..

What are the reasons for not using Valtio?
Currently, we're doing state management with React Context only. Valtio would simplify how we're doing state management.

@pkieltyka
Copy link
Member

my hope is we can keep sequence kit very lean. but I think it would be fine if we used it on some subpackages.. I will defer to @corbanbrook what he wants to do

@corbanbrook
Copy link
Collaborator

Im not against valtio, we use it successfully in other projects (market-app) and people seem to like it. Its rather small, similar in size to most other state management libs. I do respect that we want to avoid adding any unnecessary bloat, and we have a working solution with React primitives (context, useState), but as applications get more complicated its generally thought that the react primitives fall a little flat and easier DX with other state management libs.

@SamueleA SamueleA closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants