Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proxy factory for NFTs #3

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Use proxy factory for NFTs #3

wants to merge 14 commits into from

Conversation

Agusx1211
Copy link
Member

@Agusx1211 Agusx1211 commented Oct 15, 2021 •
edited
Loading

  • Use proxy factory instead of deploying full contracts
  • Add contract tests
  • Add coverage tasks (100%)
  • Cheap NFT creation (92k gas per contract)

@Agusx1211 Agusx1211 requested a review from pkieltyka October 15, 2021 16:20
pkieltyka
pkieltyka approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@pkieltyka pkieltyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks amazing, and cool to see the achievement of 92k gas deployments, that is a game changing for niftyup. Left one small comment

src/contracts/NiftyupFactory.sol Outdated Show resolved Hide resolved
@Agusx1211
Copy link
Member Author

Depends on 0xsequence/erc-1155#79

@Agusx1211 Agusx1211 requested a review from pkieltyka October 22, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkieltyka pkieltyka Awaiting requested review from pkieltyka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Agusx1211 @pkieltyka