228 marketplace reader support #263
Conversation
ZemindJan
force-pushed
the
228-marketplace-reader-support
branch
from
6c2ea09 to
bd6b8e9
Compare
Plugins/SequencePlugin/Source/SequencePlugin/Private/Tests/TestSequenceAPI.cpp
Show resolved
Hide resolved
Plugins/SequencePlugin/Source/SequencePlugin/Private/Util/JsonBuilder.cpp
Show resolved
Hide resolved
Plugins/SequencePlugin/Source/SequencePlugin/Public/Marketplace/Structs/SeqOrder.h
Outdated
Show resolved
Hide resolved
Plugins/SequencePlugin/Source/SequencePlugin/Public/Integrators/SequenceMarketplaceBP.h
Outdated
Show resolved
Hide resolved
Plugins/SequencePlugin/Source/SequencePlugin/Private/Marketplace/Marketplace.cpp
Outdated
Show resolved
Hide resolved
Plugins/SequencePlugin/Source/SequencePlugin/Private/Marketplace/Marketplace.cpp
Outdated
Show resolved
Hide resolved
Plugins/SequencePlugin/Source/SequencePlugin/Public/Marketplace/Marketplace.h
Outdated
Show resolved
Hide resolved
| [CoreRedirects] | ||
| +FunctionRedirects=(OldName="/Script/SequencePlugin.SequenceMarketplaceBP.GetCollectiblesWithLowestListingsAsync",NewName="/Script/SequencePlugin.SequenceMarketplaceBP.GetCollectiblesWithLowestListingsFirstAsync") | ||
| +FunctionRedirects=(OldName="/Script/SequencePlugin.SequenceMarketplaceBP.GetCollectiblesWithHighestListingsFirstAsync",NewName="/Script/SequencePlugin.SequenceMarketplaceBP.GetCollectiblesWithHighestPricedOffersFirstAsync") |
There was a problem hiding this comment.
Didn't know this existed
Very cool
There was a problem hiding this comment.
| const FFailureCallback& OnFailure) | ||
| { | ||
| const FString Endpoint = "ListCollectibleOffersWithHighestPricedOfferFirst"; |
There was a problem hiding this comment.
This is the wrong endpoint. Example curl request:
curl -X POST 'https://marketplace-api.sequence.app/polygon/rpc/Marketplace/ListCollectibles' -H 'Content-Type: application/json' -H 'X-Access-Key: oesk7yu5tjNfQElu5HjuUunAAAAAAAAAA' -d '{"side":"offer","contractAddress":"0x079294e6ffec16234578c672fa3fbfd4b6c48640","filter":{"includeEmpty":false,"searchText":""}}'
I understand your confusion though here; it's changed a few times. Should be finalized now though
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| #include "CoreMinimal.h" | |||
|
|
|||
| namespace IndexerEndToEndTestsCommon | |||
| namespace MarketplaceEndToEndTestsCommon | |||
There was a problem hiding this comment.
Ahh, I think I see what happened above - copy/paste error 😄
Wrong file name here
| public: | ||
| // Properties | ||
| UPROPERTY(EditAnywhere, BlueprintReadWrite) | ||
| int ID; |
There was a problem hiding this comment.
Hmm... I'm not sure if the id's are parsing properly. When I run the test I see all the id's are 0
{
"iD": 0,
"chainId": 137,
...
}
The are more fields that can be added as well, see Unity code as an example, we can add them now or in a later ticket/pr
No description provided.