Fix to prevent crashing when logging in with corrupted save file on Mac #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing function call with Encryptor, this helps prevent crashing on MacOS
BellringerQuinn
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Thank you for fixing this! Looks great 😄
Question for you: I noticed that our save file is called 'Cr.sav'. Is there any significance to that name? I'm wondering if maybe we should rename it to be something more specific like SequenceCredentials.sav? What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Try Catch to AppleBridge to ensure the the editor doesn't crash if corrupted save data is passed along to be decrypted.
If save file is found but unable to be read, it is now just removed.
Docs Checklist
Please ensure you have addressed documentation updates if needed as part of this PR: