Updating initWallet to use connected network configs if they exist #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkieltyka
reviewed
Dec 19, 2024
| if (network.rpcUrl.includes(projectAccessKey)) { | ||
| return network | ||
| } | ||
|
|
||
| // this will probably break non-sequence RPC provider URLs. | ||
| // XXX: This will probably break non-sequence RPC provider URLs. |
There was a problem hiding this comment.
lets just search for "sequence.app" in the url then, and skip adding this if thats the case..?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously dapp side would just use the default network config which pointed to production rpcUrls, etc. So there was a disconnect between the what the specified wallet was using and the dapp, so a dev project access key that would work on wallet side would not work on the dapp side production services.
This corrects it by making sure to merge in the connected sessions network config when returning providers