Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journeyers Table #34

Merged
merged 3 commits into from
Aug 11, 2020
Merged

Journeyers Table #34

merged 3 commits into from
Aug 11, 2020

Conversation

Bruck1701
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Build (gatsby build) was run locally and any changes were pushed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The app does not currently have a Journeyers page with the participants' info.

Issue Number: #7

What is the new behavior?

A table with the badge( picture and full name), Github username, Twitter username, and a progress bar of the challenge.
the table is

  • Lazily loaded ( 10 users at a time) - wrapping around at the end of the users' list
  • Sortable by name, usernames and progress
  • includes a tool tip to show the real number of days, since the progress bar only registers until 100 days (100%)

Does this introduce a breaking change?

  • Yes
  • No

Other information

added a new package : react-tooltip
There is an issue to be added: ProfileBadge component needs a feature to customize the 'justify' option for the picture and the the name inside the badge.

@Bruck1701 Bruck1701 linked an issue Aug 9, 2020 that may be closed by this pull request
@antoniolofiego antoniolofiego added this to the Full component suite milestone Aug 11, 2020
@antoniolofiego antoniolofiego added the enhancement New feature or request label Aug 11, 2020
@antoniolofiego antoniolofiego merged commit 292df3d into 100DaysOfCloud:dev Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Journeyers Page ProfileBadge needs to have an option to align the content of the badge to the left.
2 participants