Skip to content

Commit

Permalink
Merge pull request #1717 from 100mslive/FLUT-247/timed-metadata-fix
Browse files Browse the repository at this point in the history
Flut 247/timed metadata fix
  • Loading branch information
Decoder07 authored Feb 26, 2024
2 parents f90f293 + 657d061 commit f683f1e
Show file tree
Hide file tree
Showing 8 changed files with 262 additions and 247 deletions.
12 changes: 11 additions & 1 deletion packages/hms_room_kit/lib/src/meeting/meeting_store.dart
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,9 @@ class MeetingStore extends ChangeNotifier

List<HMSPollStore> hlsViewerPolls = [];

///Cue Duration for hls stream
final int _hlsCueDuration = 20;

///List of bottom sheets currently open
List<BuildContext> bottomSheets = [];

Expand Down Expand Up @@ -2775,6 +2778,13 @@ class MeetingStore extends ChangeNotifier
switch (pollUpdateType) {
///If the poll is started we add the poll in questions list
case HMSPollUpdateType.started:
if (poll.createdBy?.peerId == localPeer?.peerId) {
///Send timed metadata for polls/quiz created by local peer.
sendHLSTimedMetadata([
HMSHLSTimedMetadata(
metadata: "poll:${poll.pollId}", duration: _hlsCueDuration)
]);
}

/*
* Here we check whether the peer has permission to view polls
Expand Down Expand Up @@ -2804,7 +2814,7 @@ class MeetingStore extends ChangeNotifier
*/
if (poll.startedAt != null &&
(DateTime.now().difference(poll.startedAt!) >
const Duration(seconds: 20))) {
Duration(seconds: _hlsCueDuration))) {
insertPollQuestion(store);
toasts.add(HMSToastModel(store,
hmsToastType: HMSToastsType.pollStartedToast));
Expand Down

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions packages/hmssdk_flutter/example/ExampleAppChangelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ https://100ms.atlassian.net/browse/FLUT-211
- Polls: Quiz Ended Screen
https://100ms.atlassian.net/browse/FLUT-205

- Polls and Quizzes are not getting dispalyed for VNRT user
https://100ms.atlassian.net/browse/FLUT-247

Room Kit: 1.0.14
Core SDK: 1.9.11
Android SDK: 2.9.0
Expand Down
18 changes: 9 additions & 9 deletions packages/hmssdk_flutter/example/android/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ GEM
google-apis-firebaseappdistribution_v1 (~> 0.3.0)
google-apis-firebaseappdistribution_v1alpha (~> 0.2.0)
gh_inspector (1.1.3)
google-apis-androidpublisher_v3 (0.57.0)
google-apis-core (>= 0.12.0, < 2.a)
google-apis-core (0.13.0)
google-apis-androidpublisher_v3 (0.58.0)
google-apis-core (>= 0.14.0, < 2.a)
google-apis-core (0.14.0)
addressable (~> 2.5, >= 2.5.1)
googleauth (~> 1.9)
httpclient (>= 2.8.1, < 3.a)
Expand All @@ -132,12 +132,12 @@ GEM
google-apis-core (>= 0.11.0, < 2.a)
google-apis-firebaseappdistribution_v1alpha (0.2.0)
google-apis-core (>= 0.11.0, < 2.a)
google-apis-iamcredentials_v1 (0.18.0)
google-apis-core (>= 0.12.0, < 2.a)
google-apis-playcustomapp_v1 (0.14.0)
google-apis-core (>= 0.12.0, < 2.a)
google-apis-storage_v1 (0.33.0)
google-apis-core (>= 0.12.0, < 2.a)
google-apis-iamcredentials_v1 (0.19.0)
google-apis-core (>= 0.14.0, < 2.a)
google-apis-playcustomapp_v1 (0.15.0)
google-apis-core (>= 0.14.0, < 2.a)
google-apis-storage_v1 (0.34.0)
google-apis-core (>= 0.14.0, < 2.a)
google-cloud-core (1.6.1)
google-cloud-env (>= 1.0, < 3.a)
google-cloud-errors (~> 1.0)
Expand Down
4 changes: 2 additions & 2 deletions packages/hmssdk_flutter/example/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ android {
applicationId "live.hms.flutter"
minSdkVersion 21
targetSdkVersion 33
versionCode 446
versionName "1.5.146"
versionCode 448
versionName "1.5.148"
}

signingConfigs {
Expand Down
18 changes: 9 additions & 9 deletions packages/hmssdk_flutter/example/ios/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,9 @@ GEM
google-apis-firebaseappdistribution_v1alpha (~> 0.2.0)
fastlane-plugin-versioning (0.5.2)
gh_inspector (1.1.3)
google-apis-androidpublisher_v3 (0.57.0)
google-apis-core (>= 0.12.0, < 2.a)
google-apis-core (0.13.0)
google-apis-androidpublisher_v3 (0.58.0)
google-apis-core (>= 0.14.0, < 2.a)
google-apis-core (0.14.0)
addressable (~> 2.5, >= 2.5.1)
googleauth (~> 1.9)
httpclient (>= 2.8.1, < 3.a)
Expand All @@ -133,12 +133,12 @@ GEM
google-apis-core (>= 0.11.0, < 2.a)
google-apis-firebaseappdistribution_v1alpha (0.2.0)
google-apis-core (>= 0.11.0, < 2.a)
google-apis-iamcredentials_v1 (0.18.0)
google-apis-core (>= 0.12.0, < 2.a)
google-apis-playcustomapp_v1 (0.14.0)
google-apis-core (>= 0.12.0, < 2.a)
google-apis-storage_v1 (0.33.0)
google-apis-core (>= 0.12.0, < 2.a)
google-apis-iamcredentials_v1 (0.19.0)
google-apis-core (>= 0.14.0, < 2.a)
google-apis-playcustomapp_v1 (0.15.0)
google-apis-core (>= 0.14.0, < 2.a)
google-apis-storage_v1 (0.34.0)
google-apis-core (>= 0.14.0, < 2.a)
google-cloud-core (1.6.1)
google-cloud-env (>= 1.0, < 3.a)
google-cloud-errors (~> 1.0)
Expand Down
4 changes: 2 additions & 2 deletions packages/hmssdk_flutter/example/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ PODS:
- HMSSDK (1.5.0):
- HMSAnalyticsSDK (= 0.0.2)
- HMSWebRTC (= 1.0.5116)
- hmssdk_flutter (1.9.10):
- hmssdk_flutter (1.9.11):
- Flutter
- HMSBroadcastExtensionSDK (= 0.0.9)
- HMSHLSPlayerSDK (= 0.0.2)
Expand Down Expand Up @@ -236,7 +236,7 @@ SPEC CHECKSUMS:
HMSBroadcastExtensionSDK: d80fe325f6c928bd8e5176290b5a4b7ae15d6fbb
HMSHLSPlayerSDK: 6a54ad4d12f3dc2270d1ecd24019d71282a4f6a3
HMSSDK: 0d1901d64faf2661d1183c1ba2881e2531a5eeba
hmssdk_flutter: 1ac7183583649a88afe02b16d34b10968f3e792a
hmssdk_flutter: ecf2fb5287f3c61c0e5a6aa2a395fd39b760ab79
HMSWebRTC: ae54e9dd91b869051b283b43b14f57d43b7bf8e1
MTBBarcodeScanner: f453b33c4b7dfe545d8c6484ed744d55671788cb
nanopb: d4d75c12cd1316f4a64e3c6963f879ecd4b5e0d5
Expand Down
4 changes: 2 additions & 2 deletions packages/hmssdk_flutter/example/ios/Runner/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.5.146</string>
<string>1.5.148</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleURLTypes</key>
Expand All @@ -48,7 +48,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>446</string>
<string>448</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationCategoryType</key>
Expand Down

0 comments on commit f683f1e

Please sign in to comment.