Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Username is not honoured while skip preview is true #1807

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix: Username is not honoured while skip preview is true #1807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/hms_room_kit/lib/src/preview_meeting_flow.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ class _PreviewMeetingFlowState extends State<PreviewMeetingFlow> {
Widget build(BuildContext context) {
return HMSRoomLayout.skipPreview
? MeetingScreenController(
user: widget.prebuiltOptions?.userId ?? "",
user: widget.prebuiltOptions?.userName ??
widget.prebuiltOptions?.userId ??
"",
localPeerNetworkQuality: null,
options: widget.prebuiltOptions,
tokenData: widget.tokenData,
Expand Down
3 changes: 2 additions & 1 deletion packages/hms_room_kit/lib/src/widgets/bottom_sheets/change_role_bottom_sheet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ class ChangeRoleBottomSheetState extends State<ChangeRoleBottomSheet> {
child: HMSDropDown(
dropDownItems: <DropdownMenuItem>[
...widget.roles
.where((role) => ((role.name != widget.peer.role.name) && (role.name != '__internal_recorder')))
.where((role) => ((role.name != widget.peer.role.name) &&
(role.name != '__internal_recorder')))
.sortedBy((element) => element.priority.toString())
.map((role) => DropdownMenuItem(
value: role,
Expand Down
5 changes: 3 additions & 2 deletions packages/hms_room_kit/lib/src/widgets/bottom_sheets/remote_peer_bottom_sheet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,9 @@ class _RemotePeerBottomSheetState extends State<RemotePeerBottomSheet> {
? HMSThemeColors.onSurfaceLowEmphasis
: HMSThemeColors.onSurfaceHighEmphasis)),
if ((widget.meetingStore.localPeer?.role.permissions
.changeRole ??
false) && (widget.meetingStore.roles.length > 1))
.changeRole ??
false) &&
(widget.meetingStore.roles.length > 1))
ListTile(
horizontalTitleGap: 2,
onTap: () async {
Expand Down
4 changes: 1 addition & 3 deletions packages/hms_room_kit/lib/src/widgets/common_widgets/message_container.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,7 @@ class MessageContainer extends StatelessWidget {
mainAxisAlignment: MainAxisAlignment.end,
children: [
HMSSubtitleText(
text: message.time == null
? ""
: formatter.format(message.time!),
text: formatter.format(message.time),
textColor: HMSThemeColors.onSurfaceMediumEmphasis,
),
const SizedBox(
Expand Down
Loading