Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Vale Linter #1283

Merged
merged 67 commits into from
Dec 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
477346c
added landscape mode support
ygit Dec 1, 2023
18cb98c
landscape mode fixes
stanwolverine Dec 1, 2023
f09f792
Merge branch 'develop' into RN-153
ygit Dec 1, 2023
5b56f49
updated Example app changelog
ygit Dec 1, 2023
f5b0a76
inset chat view landscape mode fixes
stanwolverine Dec 1, 2023
71b7eab
Merge branch 'RN-153' of https://github.com/100mslive/react-native-hm…
stanwolverine Dec 1, 2023
cfd1baa
released sample app version 2.3.115 (365) ⚛️
ygit Dec 1, 2023
09cb7e7
Merge branch 'RN-153' of https://github.com/100mslive/react-native-hm…
ygit Dec 1, 2023
ecf099d
removed portrait lock from iOS app
ygit Dec 1, 2023
5f396e7
updated app version
ygit Dec 2, 2023
9b2cf5b
Merge branch 'develop' into RN-153
ygit Dec 2, 2023
ea57d6f
updated landscape handling
ygit Dec 4, 2023
6fced66
released sample app version 2.3.116 (366) ⚛️
ygit Dec 4, 2023
3c290f6
Merge branch 'develop' into RN-153
ygit Dec 4, 2023
68eeb4b
updated packages
ygit Dec 4, 2023
1f20941
formatted with trunk
ygit Dec 4, 2023
ebcf7ff
fix(sdk): :bug: screenshare publishing issue due to auto enter pip
stanwolverine Dec 5, 2023
3ada5bb
landscape bugfixes
stanwolverine Dec 5, 2023
913cbb2
released sample app version 2.3.117 (367) ⚛️
ygit Dec 5, 2023
154365e
version locked react-native-reanimated to 3.4.2
ygit Dec 5, 2023
bdc8990
inset local peer tile landscape fixes
stanwolverine Dec 5, 2023
88b80da
Merge branch 'RN-153' of https://github.com/100mslive/react-native-hm…
stanwolverine Dec 5, 2023
bec575b
released sample app version 2.3.119 (369) ⚛️
ygit Dec 5, 2023
8d227c8
Merge branch 'develop' into RN-153
ygit Dec 7, 2023
dabe50f
fix(prebuilt): :bug: removed `useAnimatedKeyboard` hook usage from an…
stanwolverine Dec 7, 2023
0b0fe7e
Merge branch 'RN-153' of https://github.com/100mslive/react-native-hm…
stanwolverine Dec 7, 2023
723e8f8
released sample app version 2.3.120 (370) ⚛️
ygit Dec 7, 2023
5a5c4e6
fix(prebuilt): :bug: publishing screenshare resolution is reverted in…
stanwolverine Dec 7, 2023
4c2ab76
Merge branch 'RN-153' of https://github.com/100mslive/react-native-hm…
stanwolverine Dec 7, 2023
3c347da
released sample app version 2.3.121 (371) ⚛️
ygit Dec 7, 2023
a021f80
updated status bar
ygit Dec 8, 2023
a11a698
released sample app version 2.3.122 (372) ⚛️
ygit Dec 8, 2023
9229b9e
initial gesture changes
stanwolverine Dec 8, 2023
dc07954
feat(prebuilt): completed hide header and footer animation
stanwolverine Dec 11, 2023
f854a82
released sample app version 2.3.123 (373) ⚛️
ygit Dec 11, 2023
4cb10da
updated packages
ygit Dec 11, 2023
b786dfa
fix(prebuilt): :bug: app crash on scree tap
stanwolverine Dec 12, 2023
9375250
Merge branch 'develop' into RN-138
ygit Dec 12, 2023
ecce941
released sample app version 2.3.124 (374) ⚛️
ygit Dec 12, 2023
6125413
fix(prebuilt): :bug: proper fix for app crash on screen tap
stanwolverine Dec 12, 2023
de74f4c
Merge branch 'RN-138' of https://github.com/100mslive/react-native-hm…
stanwolverine Dec 12, 2023
2b03424
feat(prebuilt): disable editing username if passed as prebuilt option
stanwolverine Dec 13, 2023
c02292d
fix(prebuilt): :bug: modal hiding behind keyboard
stanwolverine Dec 13, 2023
7d3517e
released sample app version 2.3.125 (375) ⚛️
ygit Dec 13, 2023
9e72d8f
added checks for safe area
ygit Dec 13, 2023
a7b2edb
fix(prebuilt): :bug: Empty local peer tile action sheet
stanwolverine Dec 13, 2023
1b97557
fix(prebuilt): :bug: footer buttons not detecting tap when any modal …
stanwolverine Dec 13, 2023
0ec34f6
Merge branch 'RN-143' of https://github.com/100mslive/react-native-hm…
stanwolverine Dec 13, 2023
b442c8d
refactor(prebuilt): modal keyboard handling in android
stanwolverine Dec 13, 2023
2e50b8a
fix(prebuilt): :bug: participants sheet safe area fixes
stanwolverine Dec 13, 2023
34fa418
released sample app version 2.3.126 (376) ⚛️
ygit Dec 13, 2023
d77c2af
Merge branch 'RN-143' of https://github.com/100mslive/react-native-hm…
ygit Dec 13, 2023
89d9c88
streaming and recording bugfixes
stanwolverine Dec 14, 2023
eb2d390
Merge branch 'RN-143' of https://github.com/100mslive/react-native-hm…
stanwolverine Dec 14, 2023
f9c1f15
released sample app version 2.3.128 (378) ⚛️
ygit Dec 14, 2023
c84a7e0
stopped emitting error when rejecting the promise (#1282)
ygit Dec 14, 2023
94ea3d6
recording button states fixes
stanwolverine Dec 14, 2023
2b35a32
Merge branch 'RN-143' of https://github.com/100mslive/react-native-hm…
stanwolverine Dec 14, 2023
7a7dd2f
released sample app version 2.3.129 (379) ⚛️
stanwolverine Dec 14, 2023
80de76b
released sample app version 2.3.129 (379) ⚛️
ygit Dec 15, 2023
5237cfb
Merge branch 'RN-143' of https://github.com/100mslive/react-native-hm…
ygit Dec 15, 2023
cbaaa9f
using flatlist from react-native-reanimated package
stanwolverine Dec 15, 2023
5b7cc04
added key prop to regular tiles flatlist
stanwolverine Dec 15, 2023
dcf6a78
added Vale linter
ygit Dec 16, 2023
5e9e362
added vale yml
ygit Dec 16, 2023
285f263
Merge branch 'develop' into updatedLinter
ygit Dec 18, 2023
7b491ed
updated Gridview
ygit Dec 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
175 changes: 175 additions & 0 deletions .github/styles/Vocab/HMSVocab/accept.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,175 @@
__main__
__name__
100ms
access_key
account_id
app_access_key
app_secret
async
beam_id
boolean
config
const
created_at
datetime
error_type
hostname
html
iat
json
JSON
jti
jwtid
meeting_url
metadata_id
metadata_timestamp
msg
nbf
npm
peer_id
presigned_url
recording_hls_vod_playlist_location
recording_single_files
recording_thumbnails
room_id
session_id
session_started_at
started_at
state_message
state_name
state_timestamp
stopped_at
sys
template_id
user_data
user_id
user_name
UUID
WebSocket
jwt
JWT
APIs
SDKs
param
Params
subscribeParams
application/json
customer_id
joined_at
left_at
TL;DR
Wowza
bitrate
custom_role_url
startedAt
meetingURL
livestream
recording_info
app_id
setVolume
trackBy
framerate
params
unmounting
HMSPeer's
hms
HMS
RTMP
HLS
URL
SDK
useEffect
DevTools
Bluetooth
Bool
downlink
YouTube
WebRTC
management_token
_id
you've
we've
We've
You've
pixelated
screenshare
unmuted
unmute
capturer
teardown
enum
nullable
subview
stringified
ProGuard
errMsg
bundler
validator
viewport
unmount
hls.failure
hls.stopped.success
hls.started.success
hls.recording.success
hls_vod_recording_path
hls_vod_recording_presigned_url
session_duration
px
broadcasted
navbar
upload_info
serializable
rtmpDestinations
hlsDestinations
WebKit
Codesandbox
autoplay
bitcode
onwards
Podfile
CocoaPods
FFmpeg
telehealth
kbps
updated_at
recording_assets
started_by
stopped_by
presign_duration
single_file_per_layer
asset_types
audio_only
hls
large_room
max_duration_seconds
codec
rtmp
txt
srt
superset
presign
output_modes
custom_vocabulary
tooltip
unmuting
sdk
autofocus
skippable
nack
pli
ssrc
tldraw
keyof
unobserve
qp
rehype
num
url
answer_max_len
answer_min_len
userid
peerid
ios
android
iOS
authToken
26 changes: 26 additions & 0 deletions .github/workflows/vale.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Vale Linter

on:
workflow_dispatch:
pull_request:
branches:
- develop
- main

permissions:
checks: write
contents: read


jobs:
vale:
name: runner / vale
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: errata-ai/vale-action@reviewdog
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
with:
fail_on_error: true
filter_mode: diff_context
14 changes: 14 additions & 0 deletions .vale.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
StylesPath = .github/styles

MinAlertLevel = error

Vocab = HMSVocab

Packages = Google, Readability

[*.{md,json,js,ts,tsx,jsx,java,kt,h,m,mm,swift}]
BasedOnStyles = Vale, Google

BlockIgnores = (?s) *(\x60\x60\x60[a-z]*\n[\s\S]*?\x60\x60\x60)

TokenIgnores = [a-f0-9]{8}-[a-f0-9]{4}-4[a-f0-9]{3}-[89aAbB][a-f0-9]{3}-[a-f0-9]{12} , r.M , (^[a-z]|[A-Z])[a-z]* , `{3}([\S]+)?\n([\s\S]+)\n`{3} , .*",
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,9 @@ import { View, FlatList, StyleSheet, useWindowDimensions, Platform } from 'react
import { useDispatch, useSelector } from 'react-redux';
import type {
LayoutChangeEvent,
LayoutRectangle,
ViewToken,
} from 'react-native';
import type { HMSView, HMSPeer } from '@100mslive/react-native-hms';
import { useSharedValue } from 'react-native-reanimated';

import { DefaultModal } from './DefaultModal';
import { SaveScreenshot } from './Modals';
Expand Down Expand Up @@ -190,6 +188,7 @@ const RegularTiles = React.forwardRef<
>(({ pairedPeers, onPeerTileMorePress, setHmsViewRefs }, flatlistRef) => {
const dispatch = useDispatch();
const { height: safeHeight } = useSafeAreaFrame();

const screenshareTilesAvailable = useSelector(
(state: RootState) => state.app.screensharePeerTrackNodes.length > 0
);
Expand Down
Loading