Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated inline code comments #1408

Merged
merged 10 commits into from
Jul 23, 2024
Merged

updated inline code comments #1408

merged 10 commits into from
Jul 23, 2024

Conversation

ygit
Copy link
Member

@ygit ygit commented Jul 18, 2024

Description

  • updated inline code comments

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I have updated the ExampleAppChangelog.txt file with relevant changes.
  • I updated/added relevant documentation (doc comments with ///).
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@ygit ygit requested a review from stanwolverine as a code owner July 18, 2024 08:13
@trunk-io Trunk.io
Copy link

trunk-io bot commented Jul 18, 2024

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@ygit ygit marked this pull request as draft July 18, 2024 14:39
@ygit ygit marked this pull request as ready for review July 18, 2024 14:49
stanwolverine
stanwolverine approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@stanwolverine stanwolverine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ygit ygit merged commit 521ea82 into develop Jul 23, 2024
0 of 6 checks passed
@ygit ygit deleted the addDocs branch July 23, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanwolverine stanwolverine stanwolverine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ygit @stanwolverine