Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved QA reported issues #1414

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Resolved QA reported issues #1414

merged 5 commits into from
Jul 31, 2024

Conversation

ygit
Copy link
Member

@ygit ygit commented Jul 30, 2024

Description

  • Resolved QA reported issues

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I have updated the ExampleAppChangelog.txt file with relevant changes.
  • I updated/added relevant documentation (doc comments with ///).
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@ygit ygit requested a review from stanwolverine as a code owner July 30, 2024 13:34
@trunk-io Trunk.io
Copy link

trunk-io bot commented Jul 30, 2024

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@ygit ygit merged commit 3f9e460 into develop Jul 31, 2024
4 of 5 checks passed
@ygit ygit deleted the resolveQAIssues branch July 31, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Decoder07 Decoder07 Decoder07 approved these changes

@stanwolverine stanwolverine Awaiting requested review from stanwolverine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ygit @Decoder07