fix: add optimisations for HMSEffectsPlugin

100mslive · Jan 27, 2025 · 1823e5b · 1823e5b
1 parent 09377a5
commit 1823e5b
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/packages/hms-virtual-background/src/HMSEffectsPlugin.ts b/packages/hms-virtual-background/src/HMSEffectsPlugin.ts
@@ -45,10 +45,15 @@ export class HMSEffectsPlugin implements HMSMediaStreamPlugin {
       if (this.effects) {
         this.initialised = true;
         this.onInit?.();
-        this.effects.run();
-        this.effects.setBackgroundFitMode('fill');
-        this.effects.setSegmentationPreset(this.preset);
-        this.applyEffect();
+        if (
+          this.background !== HMSVirtualBackgroundTypes.NONE &&
+          this.backgroundType !== HMSVirtualBackgroundTypes.NONE
+        ) {
+          this.effects.run();
+          this.effects.setBackgroundFitMode('fill');
+          this.effects.setSegmentationPreset(this.preset);
+          this.applyEffect();
+        }
       }
     };
   }
@@ -95,6 +100,7 @@ export class HMSEffectsPlugin implements HMSMediaStreamPlugin {
     this.backgroundType = HMSVirtualBackgroundTypes.BLUR;
     this.removeBackground();
     this.executeAfterInit(() => {
+      this.effects.run();
       this.effects.setBlur(this.blurAmount);
     });
   }
@@ -123,13 +129,17 @@ export class HMSEffectsPlugin implements HMSMediaStreamPlugin {
     this.backgroundType = HMSVirtualBackgroundTypes.NONE;
     this.removeBackground();
     this.removeBlur();
+    this.executeAfterInit(() => {
+      this.effects.stop();
+    });
   }
 
   setBackground(url: HMSEffectsBackground) {
     this.background = url;
     this.backgroundType = HMSVirtualBackgroundTypes.IMAGE;
     this.removeBlur();
     this.executeAfterInit(() => {
+      this.effects.run();
       this.effects.setBackground(this.background);
     });
   }
@@ -164,9 +174,6 @@ export class HMSEffectsPlugin implements HMSMediaStreamPlugin {
 
   stop() {
     this.removeEffects();
-    this.executeAfterInit(() => {
-      this.effects.stop();
-    });
   }
 
   private applyEffect() {