fix: improve button hover and focus colors #3451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aldenquimby is attempting to deploy a commit to the 100mslive Team on Vercel. A member of the Team first needs to authorize it. |
aldenquimby
commented
Jan 30, 2025
| @@ -70,7 +74,7 @@ const getButtonVariants = ( | |||
| border: `1px solid ${active}`, | |||
| }, | |||
| '&:not([disabled]):focus-visible': { | |||
| boxShadow: `0 0 0 3px ${base}`, | |||
| boxShadow: `0 0 0 3px $colors${hover}`, | |||
There was a problem hiding this comment.
${base}was rendering an invalid CSS var here. Add$colorsfixed that${base}is the background color, so it was blending in. using${hover}instead is clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3450
When danger buttons are hovered, the text is now visible:
The focus indicator also works now:
And the focus change applied to all solid (non-outlined) buttons. Focus was previously invisible and is now shown:
Implementation note, gotchas, related work and Future TODOs (optional)
Pre-launch Checklist
Merging: