[TECH] Ajouter un sous-composant d'affichage de l'état d'une certification (PIX-16534). #11395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeyffrey
added
👀 Tech Review Needed
👀 Func Review Needed
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
Jeyffrey
force-pushed
the
pix-16534-create-certification-informations-state-component
branch
5 times, most recently
from
54914fd to
38d2886
Compare
AndreiaPena
reviewed
Feb 11, 2025
admin/app/components/certifications/certification/informations.gjs
Outdated
Show resolved
Hide resolved
AndreiaPena
reviewed
Feb 11, 2025
Comment on lines
+9
to
+14
| {{#if @certification.isPublished}} | ||
| <PixTag @color="success">Publiée</PixTag> | ||
| {{/if}} | ||
| {{#if @certification.isCertificationCancelled}} | ||
| <PixTag @color="error">Annulée</PixTag> | ||
| {{/if}} |
There was a problem hiding this comment.
🥳 👍 et comme le tag annulée disparaîtra soon, encore moins d'intérêt à garder le CertificationInfoTag
AndreiaPena
reviewed
Feb 11, 2025
admin/tests/integration/components/certifications/certification/informations/state-test.gjs
Outdated
Show resolved
Hide resolved
Jeyffrey
force-pushed
the
pix-16534-create-certification-informations-state-component
branch
from
38d2886 to
d042f5a
Compare
alexandrecoin
approved these changes
Feb 12, 2025
alexandrecoin
added
Tech Review OK
🚀 Ready to Merge
Func Review OK
pix-service-auto-merge
deleted the
pix-16534-create-certification-informations-state-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
Dans l'objectif d'alléger le template
admin/app/templates/authenticated/certifications/certification/informations.hbs, il est nécessaire de réussir à alléger son unique composantadmin/app/components/certifications/certification/informations.gjs.🥓 Proposition
Commencer à faire de la composition en créant un sous-composant qui gérera l'affichage de la partie "État".
🧃 Remarques
admin/app/components/certifications/certification/informations.gjs.info-tagest utilisé uniquement dans la card "État", j'ai décidé de l'incorporer directement dans ce nouveau sous-composant.😋 Pour tester