Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TCDR-2137] Enclone deprecated #558

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[TCDR-2137] Enclone deprecated #558

wants to merge 10 commits into from

Conversation

abhijna
Copy link

@abhijna abhijna commented Nov 21, 2024

TCDR-2137

@abhijna abhijna self-assigned this Nov 21, 2024
pages/index.html.src Outdated Show resolved Hide resolved
pages/index.html.src Outdated Show resolved Hide resolved
pages/index.html.src Outdated Show resolved Hide resolved
@@ -239,7 +239,7 @@ <h2>Inputs to <span style="color:rgb(120,123,175);font-weight:900">enclone</span
<p><a name="software" style="display:block; position:relative; top:-20px;"></a></p>
<h2>The <span style="color:rgb(120,123,175);font-weight:900">enclone</span> software</h2>

<p><span style="color:rgb(120,123,175);font-weight:900">enclone</span> is beta software<sup>††</sup> released
<p><span style="color:rgb(120,123,175);font-weight:900">enclone</span> was a beta software<sup>††</sup> released
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p><span style="color:rgb(120,123,175);font-weight:900">enclone</span> was a beta software<sup>††</sup> released
<p><span style="color:rgb(120,123,175);font-weight:900">enclone</span> was beta software<sup>††</sup> released

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file appears to have been auto-generated from index.html.src but the two appear different. Was this file edited by hand?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macklin-10x I did a find in folder for the word "beta". Should I just delete this file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not this one. If anything, we should delete the .src versions since we're never going to regenerate the help site.

pages/index.html.src Outdated Show resolved Hide resolved
Comment on lines 33 to 35
#enclone is provided as a tool for use by the community to accelerate immunology research.
#enclone is only supported via
<a href="mailto:[email protected]">#[email protected]</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the enclone mailing list call-out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Tried not to touch help text and warning message here though. Could you please double check that I didn't break anything?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just delete the .src files.

yarn.lock Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants